On Thu, Sep 22, 2011 at 5:41 PM, Donnie Berkholz <firstname.lastname@example.org> wrote:
> On 09:37 Wed 21 Sep , Alec Warner wrote:
>> On Wed, Sep 21, 2011 at 6:11 AM, Donnie Berkholz <email@example.com> wrote:
>> > Not really, because when you update a bundled lib you actually make
>> > your whole app compile with it. People change the APIs of eclasses
>> > and then just let every internal consumer (ebuilds in gentoo-x86)
>> > break. Maybe if we put the burden on the one who changed the API,
>> > like the Linux kernel model, it would bother me less.
>> I think people do this for three reasons.
>> 1) There are no refactoring tools that I know of for bash.
>> 2) There exist some package maintainers that will yell at you if you
>> touch their packages for any reason.
> To refer to the Linux model again, you send patches to the maintainers,
> and they just commit them. This is much less effort than figuring out to
> handle some incomprehensible change to an already weird eclass and then
> sorting out how to deal with it across 20 or 30 packages.
In my experience maintainers do not 'just commit my patches.' But
perhaps I'm crazy.
>> 3) Breaking things means they get fixed.
>> We have this notify -> deprecate -> break workflow; I actually don't
>> mind it (but only because I've seen it used elsewhere.)
> I do, because I don't have time to deal with other people breaking my
> packages, whether they're in gentoo-x86, the science overlay, or my
> personal one. I've got more important things to deal with, within Gentoo
> and in the rest of my life.
You don't have time to fix breakages but you have time to do code reviews?
I put a code review system in the infra survey because I think
bugzilla is a poor way to track changes to the tree and there is not a
good way to get feedback or track updates. I think if we had
streamlined tools for this I'd be less concerned about mailing out
changes to 60 or 100 or 1000 packages and having any sane idea which
packages were fixed, which were pending, which packages I had not
heard from someone in a while.. etc...
> Donnie Berkholz
> Council Member / Sr. Developer
> Gentoo Linux
> Blog: http://dberkholz.com