From: | Ulrich Mueller <ulm@g.o> | ||
---|---|---|---|
To: | gentoo-dev@l.g.o | ||
Subject: | Re: [gentoo-dev] git-2: a bunch of patches to review | ||
Date: | Thu, 22 Sep 2011 07:02:09 | ||
Message-Id: | 20090.56637.726806.699495@a1i15.kph.uni-mainz.de | ||
In Reply to: | Re: [gentoo-dev] git-2: a bunch of patches to review by "Michał Górny" |
1 | > Attaching fixed version of the last two patches, and a complete |
2 | > eclass for convenience. |
3 | |
4 | Just a general comment: Is it really necessary to change all |
5 | [[ -n ${foo} ]] and [[ -z ${foo} ]] conditionals to the more obscure |
6 | [[ ${foo} ]] and [[ ! ${foo} ]]? |
7 | |
8 | The shortest possible form is not always the one that's best readable. |
9 | |
10 | Ulrich |
Subject | Author |
---|---|
Re: [gentoo-dev] git-2: a bunch of patches to review | Fabian Groffen <grobian@g.o> |
Re: [gentoo-dev] git-2: a bunch of patches to review | "Michał Górny" <mgorny@g.o> |