Gentoo Logo
Gentoo Spaceship




Note: Due to technical difficulties, the Archives are currently not up to date. GMANE provides an alternative service for most mailing lists.
c.f. bug 424647
List Archive: gentoo-dev
Navigation:
Lists: gentoo-dev: < Prev By Thread Next > < Prev By Date Next >
Headers:
To: gentoo-dev@g.o
From: David Leverton <levertond@...>
Subject: Re: versionator.eclass: convert to eshopts_{push,pop}
Date: Mon, 19 Jul 2010 21:45:22 +0100
On 19 July 2010 21:30, Mike Frysinger <vapier@g.o> wrote:
> i imagine this might be useful in some scenarios, but i think the more common
> usage is to enable things inline.  otherwise, the exported API would need to
> be wrapped internally like:
> get_all_version_components() {
>        eshopts_need _get_all_version_components -s extglob
> }

It's meant to work to just define get_all_version_components with the
assumption that extglob will be enabled, and then call eshopts_need in
global scope right after.

> although, the method we have now also
> allows for disabling of shopts before calling `die`.  not sure if that's
> important, but i think it's better to disable before all exit/termination
> points.

That's a reasonable point.

> so unless their is a consumer now we can point to in the tree, i'm inclined to
> leave this alone.

Fair enough.

> there are already eshopts_push/pop funcs that accomodate more things than the
> usage here, but i imagine you did it this way just to make testing in your
> shell easier
> -mike

It was supposed to support everything the existing functions do (not
everything demonstrated in the example for brevity), but I might have
missed something.


Replies:
Re: versionator.eclass: convert to eshopts_{push,pop}
-- Mike Frysinger
References:
versionator.eclass: convert to eshopts_{push,pop}
-- Mike Frysinger
Re: versionator.eclass: convert to eshopts_{push,pop}
-- Mike Frysinger
Re: versionator.eclass: convert to eshopts_{push,pop}
-- David Leverton
Re: versionator.eclass: convert to eshopts_{push,pop}
-- Mike Frysinger
Navigation:
Lists: gentoo-dev: < Prev By Thread Next > < Prev By Date Next >
Previous by thread:
Re: versionator.eclass: convert to eshopts_{push,pop}
Next by thread:
Re: versionator.eclass: convert to eshopts_{push,pop}
Previous by date:
Re: versionator.eclass: convert to eshopts_{push,pop}
Next by date:
Re: versionator.eclass: convert to eshopts_{push,pop}


Updated Jun 29, 2012

Summary: Archive of the gentoo-dev mailing list.

Donate to support our development efforts.

Copyright 2001-2013 Gentoo Foundation, Inc. Questions, Comments? Contact us.