Gentoo Logo
Gentoo Spaceship




Note: Due to technical difficulties, the Archives are currently not up to date. GMANE provides an alternative service for most mailing lists.
c.f. bug 424647
List Archive: gentoo-dev
Navigation:
Lists: gentoo-dev: < Prev By Thread Next > < Prev By Date Next >
Headers:
To: gentoo-dev@g.o
From: "Paweł Hajdan, Jr." <phajdan.jr@g.o>
Subject: Re: suspicious code in gnustep eclasses
Date: Tue, 29 May 2012 10:05:57 +0200
On 3/31/12 8:45 AM, Fabian Groffen wrote:
> On 30-03-2012 13:00:33 +0200, "Paweł Hajdan, Jr." wrote:
>> This is from gnustep-base.eclass:
>>
>>> egnustep_doc() {
>>>     if [[ -d ./Documentation ]] ; then
>>>         # Check documentation presence
>>>         cd "${S}"/Documentation
>>>         if [[ -f ./[mM]akefile || -f ./GNUmakefile ]] ; then
>>>             emake "${GS_ENV[@]}" all || die "doc make failed"
>>>             emake "${GS_ENV[@]}" install || die "doc install failed"
>>>         fi
>>>         cd ..
>>>     fi
>>> }
>>
>> Shouldn't those cd calls above rather be pushd/popd? It seems the above
>> assumes that CWD is "${S}" when egnustep_doc is executed, which is
>> probably true, but pushd/popd seems just safer.
> 
> Go ahead.

I've checked in this and all other changes to CVS, after testing gnustep
packages locally.

Paweł

Attachment:
signature.asc (OpenPGP digital signature)
References:
suspicious code in gnustep eclasses
-- Paweł Hajdan, Jr.
Re: suspicious code in gnustep eclasses
-- Fabian Groffen
Navigation:
Lists: gentoo-dev: < Prev By Thread Next > < Prev By Date Next >
Previous by thread:
Re: suspicious code in gnustep eclasses
Next by thread:
haskell-cabal.eclass suggestions
Previous by date:
Re: RFC: Enable FEATURES="userpriv usersandbox" by default?
Next by date:
Re: RFC: Enable FEATURES="userpriv usersandbox" by default?


Updated Jun 29, 2012

Summary: Archive of the gentoo-dev mailing list.

Donate to support our development efforts.

Copyright 2001-2013 Gentoo Foundation, Inc. Questions, Comments? Contact us.