1 |
El lun, 14-02-2011 a las 11:37 +0100, Gilles Dartiguelongue escribió: |
2 |
> Le lundi 14 février 2011 à 11:34 +0100, Pacho Ramos a écrit : |
3 |
> > El lun, 14-02-2011 a las 11:24 +0100, Gilles Dartiguelongue escribió: |
4 |
> > > Le lundi 14 février 2011 à 11:15 +0100, Pacho Ramos a écrit : |
5 |
> > > > El dom, 13-02-2011 a las 18:03 +0100, Pacho Ramos escribió: |
6 |
> > > > > Hello |
7 |
> > > > > |
8 |
> > > > > Please see attached news item for reviewing as part of the fix for |
9 |
> > > > > http://bugs.gentoo.org/show_bug.cgi?id=346491 |
10 |
> > > > > |
11 |
> > > > > Thanks |
12 |
> > > > > |
13 |
> > > > |
14 |
> > > > This is an updated news item for trying to cover Ciaran and Matthew |
15 |
> > > > suggestions: |
16 |
> > > > 1. It doesn't ask people to use USE="*" |
17 |
> > > > 2. Before sending this, I would add all cameras to base/make.defaults as |
18 |
> > > > already done for similar cases (like alsa, lcd devices and others) |
19 |
> > > > |
20 |
> > > > Do you agree with this? |
21 |
> > > > |
22 |
> > > > Thanks :-) |
23 |
> > > |
24 |
> > > no, adding all cameras is most likely a waste of time for maintainers, |
25 |
> > > it is prone to errors when cameras get added/removed which is already |
26 |
> > > complicated enough to maintain. |
27 |
> > > |
28 |
> > |
29 |
> > What kind of errors will people see? As I have just tested, if I run: |
30 |
> > CAMERAS="bbhsgdd" emerge -pv media-libs/libgphoto2 |
31 |
> > |
32 |
> > I get no error (that would be equivalent to a camera that got removed on |
33 |
> > a bump). |
34 |
> |
35 |
> I was talking about human error while adding stuff to appropriate files. |
36 |
> It happens already often enough with just the IUSE_EXPAND feature. |
37 |
> |
38 |
|
39 |
Then, as ebuild uses EAPI2, why don't enable all of them in ebuild |
40 |
itself by default? |
41 |
for camera in ${IUSE_CAMERAS}; do |
42 |
- IUSE="${IUSE} cameras_${camera}" |
43 |
+ IUSE="${IUSE} +cameras_${camera}" |
44 |
done |
45 |
|
46 |
Looks to work as expected here and wouldn't be prone to human errors |