Gentoo Logo
Gentoo Spaceship




Note: Due to technical difficulties, the Archives are currently not up to date. GMANE provides an alternative service for most mailing lists.
c.f. bug 424647
List Archive: gentoo-dev
Navigation:
Lists: gentoo-dev: < Prev By Thread Next > < Prev By Date Next >
Headers:
To: gentoo-dev@g.o
From: Samuli Suominen <ssuominen@g.o>
Subject: Re: ebuild laziness and binpkg overhead
Date: Wed, 20 Jun 2012 05:46:26 +0300
On 06/15/2012 06:10 PM, Mike Frysinger wrote:
> On Friday 15 June 2012 03:44:14 Samuli Suominen wrote:
>> On 06/13/2012 06:02 AM, Mike Frysinger wrote:
>>> i've noticed a growing trend where people put setup of variables into
>>> pkg_setup that only matter to src_* funcs presumably so they don't have
>>> to call the respective src_* func from an inherited eclass.
>>> unfortunately this adds pointless overhead to binpkgs.  can we please
>>> move away from this practice ?
>>
>> Every Xfce ebuild in gentoo-x86 is using pkg_setup() for 3 variables,
>> DOCS for src_install, PATCHES for src_prepare
>
> these are static variables, so defining them in a func is pointless

"sort of" not necessarily, 'has $useflag && PATCHES+=( )' has been used 
before, not sure if it's used in tree right now or not

>
>> and XFCONF for src_configure
>
> now you're down to one variable which means you've got one func to /properly/
> define

src_configure() still requires calling itself (xfconf_src_configure) in 
the end of the function
someone suggested writing, for example, xfconf() function that accepts 
$@ arguments so you could
src_configure() {
xfconf \
        $(use_enable foo)
}
but I don't really like that either...

src_setup() would be cool and solve all the forementioned issues

-Samuli


References:
ebuild laziness and binpkg overhead
-- Mike Frysinger
Re: ebuild laziness and binpkg overhead
-- Samuli Suominen
Re: ebuild laziness and binpkg overhead
-- Mike Frysinger
Navigation:
Lists: gentoo-dev: < Prev By Thread Next > < Prev By Date Next >
Previous by thread:
Re: ebuild laziness and binpkg overhead
Next by thread:
Re: ebuild laziness and binpkg overhead
Previous by date:
Re: Killing UEFI Secure Boot
Next by date:
Re: Killing UEFI Secure Boot


Updated Jun 29, 2012

Summary: Archive of the gentoo-dev mailing list.

Donate to support our development efforts.

Copyright 2001-2013 Gentoo Foundation, Inc. Questions, Comments? Contact us.