Gentoo Logo
Gentoo Spaceship




Note: Due to technical difficulties, the Archives are currently not up to date. GMANE provides an alternative service for most mailing lists.
c.f. bug 424647
List Archive: gentoo-dev
Navigation:
Lists: gentoo-dev: < Prev By Thread Next > < Prev By Date Next >
Headers:
To: gentoo-dev@g.o
From: Mark Loeser <halcy0n@g.o>
Subject: Re: Minor changes in python.eclass and distutils.eclass
Date: Mon, 5 Jul 2010 14:00:11 -0400
Arfrever Frehtes Taifersar Arahesis <Arfrever@g.o> said:
> 2010-07-05 18:26:40 Samuli Suominen napisał(a):
> > On 07/05/2010 07:17 PM, Arfrever Frehtes Taifersar Arahesis wrote:
> > > 2010-07-05 18:13:26 Samuli Suominen napisał(a):
> > >> On 07/05/2010 06:23 PM, Arfrever Frehtes Taifersar Arahesis wrote:
> > >>> These minor changes in python.eclass and distutils.eclass have been already
> > >>> reviewed on alias of Gentoo Python Project. It's recommended to be familiar
> > >>> with internals of current code before trying to understand these minor changes.
> > >>> Suggestions about indentation and quoting will be rejected.
> > >>>
> > >>
> > >> You have been already told to get rid of all the color customizations in
> > >> the python eclasses here:
> > >>
> > >> http://bugs.gentoo.org/show_bug.cgi?id=309057#c2
> > >> http://bugs.gentoo.org/show_bug.cgi?id=309057#c3
> > >>
> > >> [ .. ]
> > >>
> > >> http://bugs.gentoo.org/show_bug.cgi?id=309057#c5
> > >>
> > >> The bug was wrongly closed as fixed, as it's not really fixed before
> > >> it's all punted
> > > 
> > > Colors can be used with echo.
> > > 
> > 
> > Stop using echo for output and switch to standard output functions, like
> > einfo/eerror/elog/... like told in
> > http://bugs.gentoo.org/show_bug.cgi?id=309057#c5
> 
> You should read relevant part of comment #7:
> "The colors can of course be continued to be used in outputs that are purely build
> time outputting and not for communicating things for users like what cmake builds do."
> 
> python.eclass uses colors for build time outputting, which doesn't communicate anything for users.

Everyone else has already made valid points.  I'm just picking this one
to reply to now.  Please remove the colors you have added.  If you need
a new function, say "eqawarn", we should have that added in the next
EAPI with a description of when and where to use it.  In the meantime,
Petteri proposed a nice solution awhile back that would centralize this
so it is not a one-off hack.  Here is a link to his original proposal:

http://archives.gentoo.org/gentoo-dev/msg_44d395a1b887468051a1e1c049e99ba3.xml

Thanks,

-- 
Mark Loeser
email         -   halcy0n AT gentoo DOT org
email         -   mark AT halcy0n DOT com
web           -   http://www.halcy0n.com
Attachment:
signature.asc (Digital signature)
Replies:
Re: Minor changes in python.eclass and distutils.eclass
-- Arfrever Frehtes Taifersar Arahesis
References:
Minor changes in python.eclass and distutils.eclass
-- Arfrever Frehtes Taifersar Arahesis
Re: Minor changes in python.eclass and distutils.eclass
-- Arfrever Frehtes Taifersar Arahesis
Re: Minor changes in python.eclass and distutils.eclass
-- Samuli Suominen
Re: Minor changes in python.eclass and distutils.eclass
-- Arfrever Frehtes Taifersar Arahesis
Navigation:
Lists: gentoo-dev: < Prev By Thread Next > < Prev By Date Next >
Previous by thread:
Re: Minor changes in python.eclass and distutils.eclass
Next by thread:
Re: Minor changes in python.eclass and distutils.eclass
Previous by date:
Re: Minor changes in python.eclass and distutils.eclass
Next by date:
Re: Minor changes in python.eclass and distutils.eclass


Updated Jun 29, 2012

Summary: Archive of the gentoo-dev mailing list.

Donate to support our development efforts.

Copyright 2001-2013 Gentoo Foundation, Inc. Questions, Comments? Contact us.