Gentoo Archives: gentoo-dev

From: Pacho Ramos <pacho@g.o>
To: Gilles Dartiguelongue <eva@g.o>
Cc: gentoo-dev@l.g.o, pr@g.o, gnome <gnome@g.o>
Subject: Re: [gentoo-dev] libgphoto2-2.4.10 news item
Date: Mon, 14 Feb 2011 10:44:24
Message-Id: 1297680155.7123.11.camel@localhost.localdomain
In Reply to: Re: [gentoo-dev] libgphoto2-2.4.10 news item by Pacho Ramos
1 El lun, 14-02-2011 a las 11:40 +0100, Pacho Ramos escribió:
2 > El lun, 14-02-2011 a las 11:37 +0100, Gilles Dartiguelongue escribió:
3 > > Le lundi 14 février 2011 à 11:34 +0100, Pacho Ramos a écrit :
4 > > > El lun, 14-02-2011 a las 11:24 +0100, Gilles Dartiguelongue escribió:
5 > > > > Le lundi 14 février 2011 à 11:15 +0100, Pacho Ramos a écrit :
6 > > > > > El dom, 13-02-2011 a las 18:03 +0100, Pacho Ramos escribió:
7 > > > > > > Hello
8 > > > > > >
9 > > > > > > Please see attached news item for reviewing as part of the fix for
10 > > > > > > http://bugs.gentoo.org/show_bug.cgi?id=346491
11 > > > > > >
12 > > > > > > Thanks
13 > > > > > >
14 > > > > >
15 > > > > > This is an updated news item for trying to cover Ciaran and Matthew
16 > > > > > suggestions:
17 > > > > > 1. It doesn't ask people to use USE="*"
18 > > > > > 2. Before sending this, I would add all cameras to base/make.defaults as
19 > > > > > already done for similar cases (like alsa, lcd devices and others)
20 > > > > >
21 > > > > > Do you agree with this?
22 > > > > >
23 > > > > > Thanks :-)
24 > > > >
25 > > > > no, adding all cameras is most likely a waste of time for maintainers,
26 > > > > it is prone to errors when cameras get added/removed which is already
27 > > > > complicated enough to maintain.
28 > > > >
29 > > >
30 > > > What kind of errors will people see? As I have just tested, if I run:
31 > > > CAMERAS="bbhsgdd" emerge -pv media-libs/libgphoto2
32 > > >
33 > > > I get no error (that would be equivalent to a camera that got removed on
34 > > > a bump).
35 > >
36 > > I was talking about human error while adding stuff to appropriate files.
37 > > It happens already often enough with just the IUSE_EXPAND feature.
38 > >
39 >
40 > Then, as ebuild uses EAPI2, why don't enable all of them in ebuild
41 > itself by default?
42 > for camera in ${IUSE_CAMERAS}; do
43 > - IUSE="${IUSE} cameras_${camera}"
44 > + IUSE="${IUSE} +cameras_${camera}"
45 > done
46 >
47 > Looks to work as expected here and wouldn't be prone to human errors
48
49 Bleh, forget it, it is a headache to disable cameras then :-S

Attachments

File name MIME type
signature.asc application/pgp-signature

Replies

Subject Author
Re: [gentoo-dev] libgphoto2-2.4.10 news item Gilles Dartiguelongue <eva@g.o>
Re: [gentoo-dev] libgphoto2-2.4.10 news item Ciaran McCreesh <ciaran.mccreesh@××××××××××.com>