1 |
On Saturday 03 July 2010 12:33:17 Jeremy Olexa wrote: |
2 |
> On Fri, 2 Jul 2010 23:59:34 +0000 (UTC), "Keri Harris (keri)" |
3 |
> |
4 |
> <keri@g.o> wrote: |
5 |
> > Index: pedro-1.5.ebuild |
6 |
> > =================================================================== |
7 |
> > # Copyright 1999-2010 Gentoo Foundation |
8 |
> > # Distributed under the terms of the GNU General Public License v2 |
9 |
> > # $Header: /var/cvsroot/gentoo-x86/net-misc/pedro/pedro-1.5.ebuild,v |
10 |
> > 1.1 2010/07/02 23:59:34 keri Exp $ |
11 |
> > |
12 |
> > EAPI=1 |
13 |
> > |
14 |
> > inherit eutils |
15 |
> |
16 |
> Why do you need to inherit eutils? Nothing uses it. |
17 |
> |
18 |
> > DESCRIPTION="Pedro is a subscription/notification communications system" |
19 |
> > HOMEPAGE="http://www.itee.uq.edu.au/~pjr/HomePages/PedroHome.html" |
20 |
> > SRC_URI="http://www.itee.uq.edu.au/~pjr/HomePages/PedroFiles/${P}.tgz |
21 |
> > |
22 |
> > doc? ( mirror://gentoo/${PN}-manual-${PV}.tar.gz )" |
23 |
> > |
24 |
> > LICENSE="GPL-2" |
25 |
> > SLOT="0" |
26 |
> > KEYWORDS="~amd64 ~ppc ~sparc ~x86" |
27 |
> > IUSE="doc examples" |
28 |
> > |
29 |
> > DEPEND="dev-libs/glib:2" |
30 |
> > |
31 |
> > S="${WORKDIR}"/${P} |
32 |
> > |
33 |
> > src_unpack() { |
34 |
> > |
35 |
> > unpack ${A} |
36 |
> > cd "${S}" |
37 |
> > |
38 |
> > } |
39 |
> |
40 |
> This is the default src_unpack and can be dropped. |
41 |
> |
42 |
> > src_compile() { |
43 |
> > |
44 |
> > econf || die "econf failed" |
45 |
> > emake || die "emake failed" |
46 |
> > |
47 |
> > } |
48 |
> |
49 |
> econf() doesn't need "|| die" but furthermore, this is the default |
50 |
> src_compile and can be dropped. |
51 |
> |
52 |
> > src_install() { |
53 |
> > |
54 |
> > emake DESTDIR="${D}" install || die "emake install failed" |
55 |
> > |
56 |
> > dodoc AUTHORS README |
57 |
> > |
58 |
> > if use doc ; then |
59 |
> > |
60 |
> > dodoc "${WORKDIR}"/${PN}.pdf |
61 |
> > |
62 |
> > fi |
63 |
> > |
64 |
> > if use examples ; then |
65 |
> > |
66 |
> > insinto /usr/share/doc/${PF}/examples |
67 |
> > doins src/examples/*.{c,tcl} |
68 |
> > doins src/java_api/*.java |
69 |
> > doins src/python_api/*.py |
70 |
> > |
71 |
> > fi |
72 |
> > |
73 |
> > } |
74 |
> |
75 |
> Those are just cosmetic fixes above, but this should be fixed: |
76 |
> |
77 |
> * QA Notice: Files built without respecting LDFLAGS have been detected |
78 |
> * Please include the following list of files in your report: |
79 |
> * /usr/bin/pedro |
80 |
> * /usr/bin/ptick |
81 |
|
82 |
Thanks for the comments. I'll take care of these. |
83 |
|
84 |
Keri |