Gentoo Archives: gentoo-dev

From: "Michał Górny" <mgorny@g.o>
To: gentoo-dev@l.g.o
Cc: maksbotan@g.o, 0xd34df00d@×××××.com
Subject: Re: [gentoo-dev] Re: RFC: leechcraft.eclass
Date: Thu, 18 Aug 2011 18:42:11
Message-Id: 20110818204223.07a34c33@pomiocik.lan
In Reply to: Re: [gentoo-dev] Re: RFC: leechcraft.eclass by Maxim Koltsov
1 On Thu, 18 Aug 2011 22:33:15 +0400
2 Maxim Koltsov <maksbotan@g.o> wrote:
3
4 > if [[ -z "${LEECHCRAFT_PACKAGE_CATEGORY}" ]]; then
5 > CMAKE_USE_DIR="${S}"/src/plugins/${LEECHCRAFT_PACKAGE_CATEGORY}/${PN#leechcraft-}
6
7 Dude, that's the opposite.
8
9 > elif [[ ${PN} != "leechcraft-core" ]]; then
10 > CAKE_USE_DIR="${S}"/src/plugins/${PN#leechcraft-}
11
12 Don't quote that. It looks bad that the left-side is unquoted and right
13 side is quoted.
14
15 --
16 Best regards,
17 Michał Górny

Attachments

File name MIME type
signature.asc application/pgp-signature

Replies

Subject Author
Re: [gentoo-dev] Re: RFC: leechcraft.eclass Fabian Groffen <grobian@g.o>