| 1 |
On 02-12-2009 09:57:37 +0100, Tomáš Chvátal wrote: |
| 2 |
> Dne středa 02 Prosinec 2009 09:51:25 Christian Faulhammer napsal(a): |
| 3 |
> > At the moment I don't remember for what reason exactly, but we renamed |
| 4 |
> > the PATCHES variable to EBZR_PATCHES in bzr.eclass. You should do |
| 5 |
> > something similar. |
| 6 |
> No reason to rename it if they use base_src_prepare |
| 7 |
> > |
| 8 |
> > EXPORT_FUNCTIONS src_unpack src_prepare src_configure src_compile |
| 9 |
> > src_test src_install pkg_setup |
| 10 |
> > |
| 11 |
> > case ${EAPI} in |
| 12 |
> > 2) ;; |
| 13 |
> > *) |
| 14 |
> > die "Unsupported EAPI=${EAPI} for ruby-ng.eclass" |
| 15 |
> > esac |
| 16 |
> > |
| 17 |
> > The sense of this I don't understand. You should not restrict EAPI |
| 18 |
> > like this. |
| 19 |
> > |
| 20 |
> > V-Li |
| 21 |
> > |
| 22 |
> Why not. Quite standart way. |
| 23 |
> 19 case ${EAPI:-0} in |
| 24 |
> 20 2) : ;; |
| 25 |
> 21 *) DEPEND="EAPI-TOO-OLD" ;; |
| 26 |
> 22 esac |
| 27 |
|
| 28 |
I guess you better add a section for known eapis that are too old to |
| 29 |
your liking, and use the *) section for an oops message saying you don't |
| 30 |
know about ${EAPI} yet, and to please file a bug. |
| 31 |
|
| 32 |
|
| 33 |
|
| 34 |
-- |
| 35 |
Fabian Groffen |
| 36 |
Gentoo on a different level |
Archives