| 1 |
On 28/06/11 10:53, Michał Górny wrote: |
| 2 |
> On Tue, 28 Jun 2011 10:48:48 +0200 Michał Górny <mgorny@g.o> |
| 3 |
> wrote: |
| 4 |
|
| 5 |
I'm a noob in Python, but I disagree with this patch. for two reasons: |
| 6 |
|
| 7 |
First, the -X option is already available, and controlled by makelinks, |
| 8 |
so why not change the default value of makelinks to False? |
| 9 |
|
| 10 |
Second, after trying to understand the code, if your proposed patch is |
| 11 |
applied, the makelinks variable become useless. So why not remove it |
| 12 |
completly from the source? Is this variable still needed? |
| 13 |
|
| 14 |
There is some bunch of code starting at line 222 in the current HEAD, |
| 15 |
which sets makelinks to False upon some conditions, does this need to be |
| 16 |
refactored / removed somehow too? |
| 17 |
|
| 18 |
-- |
| 19 |
Cyprien Nicolas (fulax) |
| 20 |
Lisp project contributor |
Archives