| 1 |
>>>>> On Sat, 7 Jan 2012, Ulrich Mueller wrote: |
| 2 |
|
| 3 |
> Some functions in eutils.eclass address very special tasks, so I |
| 4 |
> wonder if they shouldn't be split out to dedicated eclasses: |
| 5 |
|
| 6 |
> - CDROM functions (cdrom_get_cds, cdrom_load_next_cd). |
| 7 |
> These are used by some 40 ebuilds only, most of them in games-*. |
| 8 |
> Maybe they could be moved to a dedicated cdrom.eclass? |
| 9 |
|
| 10 |
A draft version for a new cdrom.eclass is attached. It contains the |
| 11 |
cdrom_* functions split out from eutils.eclass. Mike says that the new |
| 12 |
eclass could be maintained by the games team. |
| 13 |
|
| 14 |
Please review. |
| 15 |
|
| 16 |
As far as I can see, eutils.eclass doesn't need to inherit |
| 17 |
portability.eclass any more, because it was only used in the cdrom |
| 18 |
functions for get_mounts(). It would be nice if somebody could |
| 19 |
double-check this. |
| 20 |
|
| 21 |
(I don't include a diff for eutils.eclass, since apart from the change |
| 22 |
in inherit it would be some 200 removal lines only.) |
| 23 |
|
| 24 |
> - unpack_pdv() is used by one ebuild in the tree only. |
| 25 |
|
| 26 |
Mike told me that it should stay together with unpack_makeself(), |
| 27 |
so I won't touch this one. |
| 28 |
|
| 29 |
Ulrich |
Archives