Gentoo Logo
Gentoo Spaceship




Note: Due to technical difficulties, the Archives are currently not up to date. GMANE provides an alternative service for most mailing lists.
c.f. bug 424647
List Archive: gentoo-dev
Navigation:
Lists: gentoo-dev: < Prev By Thread Next > < Prev By Date Next >
Headers:
To: gentoo-dev@g.o
From: Mike Frysinger <vapier@g.o>
Subject: Re: RFC: media-sound/xmms2/xmms2-0.7.ebuild
Date: Tue, 29 Jun 2010 02:24:13 -0400
>	if [[ -z "$1" ]]; then

either lose the quotes or lose the double brackets.  hint: the former.

> 		echo "!!! xmms2_flag() called without a parameter." >&2
>		echo "!!! xmms2_flag() <USEFLAG> [<xmms2_flagname>]" >&2

use eerror or die

> 			if use "$1"; then

USE flag cannot contain spaces or anything else that requires quoting

> 			else
>				: # nothing is generated
>			fi

my, we sure do like to be verbose

> 			--destdir="${D}" \

you need to give the DESTDIR to configure ?  no wonder xmms2 sucks

>			${CTARGET:+--with-target-platform=${CTARGET}} \

i highly suspect this isnt what you think it is.  if this option is for cross-
compiling, then use ${CHOST}.

>			optionals+="$(xmms2_flag $option)"

dont need the quoting when doing ...=$(...)

>	"${S}"/waf

the default dir for most src_* funcs is $S, so just use ./waf

>	use python && python_mod_optimize $(python_get_sitedir)/xmmsclient

shouldnt sitedir be quoted ?
-mike
Attachment:
signature.asc (This is a digitally signed message part.)
Replies:
Re: RFC: media-sound/xmms2/xmms2-0.7.ebuild (v2)
-- Sergei Trofimovich
Re: RFC: media-sound/xmms2/xmms2-0.7.ebuild
-- Ɓukasz Michalik
References:
RFC: media-sound/xmms2/xmms2-0.7.ebuild
-- Sergei Trofimovich
Navigation:
Lists: gentoo-dev: < Prev By Thread Next > < Prev By Date Next >
Previous by thread:
RFC: media-sound/xmms2/xmms2-0.7.ebuild
Next by thread:
Re: RFC: media-sound/xmms2/xmms2-0.7.ebuild
Previous by date:
Re: Adding --as-needed to LDFLAGS in profiles/default/linux/make.defaults
Next by date:
[OT] h v l


Updated Jun 29, 2012

Summary: Archive of the gentoo-dev mailing list.

Donate to support our development efforts.

Copyright 2001-2013 Gentoo Foundation, Inc. Questions, Comments? Contact us.