Gentoo Logo
Gentoo Spaceship




Note: Due to technical difficulties, the Archives are currently not up to date. GMANE provides an alternative service for most mailing lists.
c.f. bug 424647
List Archive: gentoo-dev
Navigation:
Lists: gentoo-dev: < Prev By Thread Next > < Prev By Date Next >
Headers:
To: gentoo-dev@g.o
From: Mike Frysinger <vapier@g.o>
Subject: Re: [PATCH eutils] Introduce prune_libtool_files().
Date: Tue, 5 Jun 2012 02:00:34 -0400
On Thursday 31 May 2012 08:55:25 Michał Górny wrote:
> +# Note: this function implicitly calls pkg-config. You should add it to
> +# your DEPEND when using it.

should clarify: implicitly calls pkg-config when your package provides a .pc.

> +	if [[ ! ${removing_all} ]]; then
> +		local f
> +		local tf=${T}/prune-lt-files.pc
> +		local pkgconf=$(tc-getPKG_CONFIG)
> +
> +		while IFS= read -r -d '' f; do # for all .pc files
> +			sed -e '/^Requires:/d' "${f}" > "${tf}"
> +			for arg in $("${pkgconf}" --libs "${tf}"); do

missing `local arg`

> +		done < <(find "${D}" -type f -name '*.pc' -print0)

not a big deal since it'll get cleaned anyways, but this doesn't clean up $tf 
when done

if no one else has feedback, i guess merge it
-mike
Attachment:
signature.asc (This is a digitally signed message part.)
Replies:
Re: [PATCH eutils] Introduce prune_libtool_files().
-- Michał Górny
References:
Re: [PATCH eutils] Move remove_libtool_files() from autotools-utils for wider use.
-- Mike Frysinger
[PATCH eutils] Introduce prune_libtool_files().
-- Michał Górny
Navigation:
Lists: gentoo-dev: < Prev By Thread Next > < Prev By Date Next >
Previous by thread:
[PATCH eutils] Introduce prune_libtool_files().
Next by thread:
Re: [PATCH eutils] Introduce prune_libtool_files().
Previous by date:
Re: Git braindump: 1 of N: merging & git signing
Next by date:
Re: multiprocessing.eclass: doing parallel work in bash


Updated Jun 29, 2012

Summary: Archive of the gentoo-dev mailing list.

Donate to support our development efforts.

Copyright 2001-2013 Gentoo Foundation, Inc. Questions, Comments? Contact us.