Gentoo Archives: gentoo-dev

From: Marc Schiffbauer <marc@×××××××××××.net>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] git-2.eclass final review
Date: Tue, 05 Apr 2011 15:18:42
Message-Id: 20110405151801.GA16173@bart
In Reply to: Re: [gentoo-dev] git-2.eclass final review by Mike Frysinger
1 * Mike Frysinger schrieb am 23.03.11 um 00:08 Uhr:
2 > 2011/3/22 TomᨠChvátal:
3 > > Dne 22.3.2011 22:26, Mike Frysinger napsal(a):
4 > >>> # @BLURB: This eclass provides functions for fetch and unpack git repositories
5 > >>
6 > >> fetching/unpacking
7 > >
8 > > Yarp fixed.
9 >
10 > well, the fix broke the blurb. it has to be on one line.
11 > # @BLURB: foo
12 >
13 > > EGIT_BRANCH=${x:-${EGIT_BRANCH:=${EGIT_MASTER}}}
14 > > EGIT_COMMIT=${x:-${EGIT_COMMIT:=${EGIT_BRANCH}}}
15 >
16 > doesnt make much sense to use := ... it should be :-
17 >
18 > > [[ "$#" -ne 1 ]] && die "${FUNCNAME}: requires 1 argument (path)"
19 >
20 > quoting doesnt make much sense ... -ne compares an int, not a string
21
22 If using [[ you never need to quote anyway.
23
24 -Marc
25 --
26 8AAC 5F46 83B4 DB70 8317 3723 296C 6CCA 35A6 4134