Gentoo Archives: gentoo-dev

From: Thomas Sachau <tommy@g.o>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in media-libs/mlt: ChangeLog mlt-0.5.4-r1.ebuild
Date: Sun, 15 Aug 2010 08:14:08
Message-Id: 4C67A1BC.4020703@gentoo.org
In Reply to: Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in media-libs/mlt: ChangeLog mlt-0.5.4-r1.ebuild by "Harald van Dijk"
1 Am 14.08.2010 19:35, schrieb Harald van Dijk:
2 > On Sat, Aug 14, 2010 at 06:26:12PM +0200, Thilo Bangert wrote:
3 >>> So you want me to force everyone to update the package just to respect
4 >>> the LDFLAGS.
5 >>
6 >> yes. IIRC it has been stated on this list before, that a change which
7 >> changes the resulting binary always needs to be done in a revbump.
8 >
9 > If that's true, that doesn't make sense. Take one extreme case: let's
10 > say libgcj, part of gcc, has a problem with LDFLAGS, and you fixed it.
11 > But the majority of people using gcc don't even turn on java support,
12 > those that do have a working libgcj already, and gcc can easily take
13 > hours to build. Should you revbump?
14 >
15 > There are always exceptions. Maybe you don't consider LDFLAGS support
16 > in general one of those exceptions, but clearly some others do. You
17 > can't just tell them "there are no exceptions" when there are, you need
18 > to explain why this isn't a valid reason to make an exception.
19 > My impression, too, is that few people care enough about LDFLAGS support
20 > to want to rebuild packages for it, so I would not have bumped either,
21 > but I'm willing to be convinced I'm wrong.
22 >
23 >
24
25 This is a nice example, why we should not create fixed rules for everything, but allow common rules
26 with the usage of common sense. If we now create a rule, which says "Bump on every change, always
27 and forever", people will complain for big things like gcc, openoffice or kdelibs. Instead, we have
28 a general rule, which every developer should learn at least from his mentor to revbump on every
29 change for installed files, but also to use common sense. In the case of openoffice for example, it
30 does not get a new version or revision for some minor updates, since rebuilding openoffice does take
31 much time and resources. The same should apply for your example of LDFLAGS for gcc, so you can do it
32 without a revbump there or wait, until a version bump comes in and directly add it there.
33
34 So while general, non-fixed rules may result in some discussions, they also allow adjustments in a
35 case by case decision, a fixed "Always revbump" rule creates issues at least for corner cases, in
36 this case packages with very long compile times.
37
38 --
39 Thomas Sachau
40
41 Gentoo Linux Developer

Attachments

File name MIME type
signature.asc application/pgp-signature