| 1 |
On 04/29/2012 09:45 AM, Petteri Räty wrote: |
| 2 |
> On 15.04.2012 17:12, Pacho Ramos wrote: |
| 3 |
>> El dom, 15-04-2012 a las 16:02 +0200, Michał Górny escribió: |
| 4 |
>>> On Sun, 15 Apr 2012 11:59:50 +0200 |
| 5 |
>>> Pacho Ramos <pacho@g.o> wrote: |
| 6 |
>>> |
| 7 |
>>>> I am unsure about validate_desktop_entries() utility. It's currently |
| 8 |
>>>> provided by eutils.eclass and only called by net-firewall/fwbuilder. |
| 9 |
>>>> Shouldn't this be moved to a "qa" check? Current way is pretty useless |
| 10 |
>>>> as it's not used by most of packages, and calling it from a lot of |
| 11 |
>>>> eclasses/ebuilds doesn't sound me like a good idea. |
| 12 |
>>>> |
| 13 |
>>>> What do you think? |
| 14 |
>>> |
| 15 |
>>> Agreed. It should be in repoman. |
| 16 |
>>> |
| 17 |
>> |
| 18 |
>> The check needs to be run over desktop file going to be installed, not |
| 19 |
>> sure how repoman can handle it, it looked to me more like a emerge job |
| 20 |
>> (like is done with other qa checks run before installation) |
| 21 |
> |
| 22 |
> There's actually already code in repoman that runs |
| 23 |
> desktop-file-validate. It of course only works for installed packages. |
| 24 |
> Someone could make it run runtime too. |
| 25 |
|
| 26 |
The repoman code works on $FILESDIR. It looks like we also want to run |
| 27 |
it after src_install. |
| 28 |
|
| 29 |
Also, it looks like we might need to handle a special case for Konqueror |
| 30 |
Service Menus: |
| 31 |
|
| 32 |
https://bugs.gentoo.org/show_bug.cgi?id=414125 |
| 33 |
-- |
| 34 |
Thanks, |
| 35 |
Zac |
Archives