Gentoo Logo
Gentoo Spaceship

Installation:
Gentoo Handbook
Installation Docs

Documentation:
Home
Listing
About Gentoo
Philosophy
Social Contract

Resources:
Bug Tracker
Developer List
Discussion Forums
Gentoo BitTorrents
Gentoo Linux Enhancement Proposals
IRC Channels
Mailing Lists
Mirrors
Name and Logo Guidelines
Online Package Database
Security Announcements
Staffing Needs
Supporting Vendors
View our CVS

Graphics:
Logos and themes
Icons
ScreenShots

Miscellaneous Resources:
Gentoo Linux Store
Gentoo-hosted projects
IBM dW/Intel article archive




List Archive: gentoo-dev
Navigation:
Lists: gentoo-dev: < Prev By Thread Next > < Prev By Date Next >
Headers:
To: gentoo-dev@g.o
From: Serkan Kaba <serkan@g.o>
Subject: Re: Please avoid absolute paths in patched filenames
Date: Mon, 17 Nov 2008 21:29:28 +0200
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

This check was added to epatch all of a sudden breaking all working
patches in the tree, although defending those patches having absolute
paths, we as Java team had several bugs filed due to that. Maybe the
tree should be scanned for those and fixed.

Diego 'Flameeyes' Pettenò yazmış:
> I ask it here as a favour, please avoid using absolute paths in the
> filenames of patched files. This mean avoid having stuff like
> 
> --- foobar/foo.c
> +++ /tmp/foobar/foobar.c
> 
> This tends to break from time to time, and I had to fix at least three
> packages since I started my treewide build for these problems. I already
> asked Zac about adding such a check on repoman, but in the mean time I'd
> like to ask here for people to verify their packages.
> 
> I actually am culprit of doing this some time ago but I learnt my lesson
> the hard way :P My suggestion for everybody else is to use quilt when
> you need to write patches.
> 
> And if you have patches with the filenames like I shown above, you can
> change it the git way so that it becomes:
> 
> --- a/foobar/foo.c
> +++ b/foobar/foo.c
> 
> and the problem is usually solved.
> 
> Thanks,

- --
Sincerely,
Serkan KABA
Gentoo/Java
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkkhxhgACgkQRh6X64ivZaK4wwCeIUCZ6BIqWvo7tiFXpXa+Njpe
AL4An2E5N+yGaIfv1kPaV4Gc9W8DG3M3
=2nhY
-----END PGP SIGNATURE-----


Replies:
Re: Please avoid absolute paths in patched filenames
-- Diego 'Flameeyes' Pettenò
References:
Please avoid absolute paths in patched filenames
-- Diego 'Flameeyes' Pettenò
Navigation:
Lists: gentoo-dev: < Prev By Thread Next > < Prev By Date Next >
Previous by thread:
Please avoid absolute paths in patched filenames
Next by thread:
Re: Please avoid absolute paths in patched filenames
Previous by date:
Please avoid absolute paths in patched filenames
Next by date:
Re: Please avoid absolute paths in patched filenames


Updated Jun 17, 2009

Donate to support our development efforts.

Gentoo Centric Hosting: vr.org

VR Hosted

Tek Alchemy

Tek Alchemy

SevenL.net

SevenL.net

php|architect

php|architect

Copyright 2001-2007 Gentoo Foundation, Inc. Questions, Comments? Email www@gentoo.org.