Gentoo Logo
Gentoo Spaceship




Note: Due to technical difficulties, the Archives are currently not up to date. GMANE provides an alternative service for most mailing lists.
c.f. bug 424647
List Archive: gentoo-dev
Navigation:
Lists: gentoo-dev: < Prev By Thread Next > < Prev By Date Next >
Headers:
To: gentoo-dev@g.o
From: Brian Harring <ferringb@...>
Subject: Re: New eclass: autotools-utils.eclass
Date: Sat, 17 Jul 2010 19:28:13 -0700
On Sun, Jul 18, 2010 at 01:54:43AM +0000, Jorge Manuel B. S. Vicetto wrote:
> this is being used in the tree already.

Doesn't make it right ;)

> IIRC, since the introduction of EAPI-2 in the tree, there were a few
> solutions present to the dev ml and the one agreed by people was the
> abuse of depend to have the PM fail on dependency resolution instead of
> calling die on an eclass - which iirc is / was forbidden by PMS.

PMS has no such restriction as far as I know (or can grep for).  
Regardless, if PMS *did* forbid die's in eclass global scope... pretty 
much it's there already (including for when EAPI isn't at the correct 
value).

Basically, a die can be dealt with better than broken atom's- 
DEPEND=eapi-too-old definitely conflicts w/ PMS (invalid atom), if die 
does in this case... the lesser of two evils is die.

If PMS doesn't conflict (which I'm pretty sure it doesn't), then that 
leaves die as the proper approach.


> We can discuss the correctness of this use, but please take into account
> it's already being used so until we have such a discussion we can't
> "forbid" its use.

Yes we can.  The fact it slipped in via 3 places that no one noticed 
doesn't mean it's now considerable acceptable.  This is part of what 
triggered my rant- the tree is large and vast, sometimes monsters 
manage to get added and lurk for a while.  That doesn't make them 
defacto standard however.

At the time of it's addition, it was invalid from the parsing 
standpoint- it shouldn't have been added in the first place because of 
that.

As for converting it to die, that can be done _now_ without fallout- 
if anything was triggering that codepath bones should've been 
complaining about it (yet to hear any such complaints).

~harring
Attachment:
pgpRwqeVqrYHv.pgp (PGP signature)
References:
New eclass: autotools-utils.eclass
-- Maciej Mrozowski
Re: New eclass: autotools-utils.eclass
-- Alexis Ballier
Re: New eclass: autotools-utils.eclass
-- Brian Harring
Re: New eclass: autotools-utils.eclass
-- Jorge Manuel B. S. Vicetto
Navigation:
Lists: gentoo-dev: < Prev By Thread Next > < Prev By Date Next >
Previous by thread:
Re: New eclass: autotools-utils.eclass
Next by thread:
Re: New eclass: autotools-utils.eclass
Previous by date:
Re: New eclass: autotools-utils.eclass
Next by date:
Re: Re: [gentoo-council] Upcoming Council meeting on July 26th, 1900 UTC


Updated Jun 29, 2012

Summary: Archive of the gentoo-dev mailing list.

Donate to support our development efforts.

Copyright 2001-2013 Gentoo Foundation, Inc. Questions, Comments? Contact us.