Gentoo Logo
Gentoo Spaceship




Note: Due to technical difficulties, the Archives are currently not up to date. GMANE provides an alternative service for most mailing lists.
c.f. bug 424647
List Archive: gentoo-dev
Navigation:
Lists: gentoo-dev: < Prev By Thread Next > < Prev By Date Next >
Headers:
To: gentoo-dev@g.o
From: Alec Warner <antarus@g.o>
Subject: Re: [PATCH] prune_libtool_files(): go into .a removal only when .a exists.
Date: Sat, 16 Jun 2012 01:07:53 -0700
On Fri, Jun 15, 2012 at 1:08 PM, Mike Frysinger <vapier@g.o> wrote:
> On Friday 15 June 2012 12:54:16 Michał Górny wrote:
>> On Fri, 15 Jun 2012 11:11:44 -0400 Michael Orlitzky wrote:
>> > On 06/15/12 09:32, Michał Górny wrote:
>> > > It is a little confusing when the function reports .a removal when
>> > > no such file exists. Also, explain why the file is removed.
>> >
>> > Why keep the "-f"?
>>
>> For rm?
>>
>>        -f, --force
>>               ignore nonexistent files and arguments, never prompt
>>
>> The second part is still valid.
>
> i think his point was that since you just did a [[ -f ]] test, there shouldn't
> really be any cases where the rm would fail, so you could change the `rm -f`
> to `rm || die` ...
> -mike

Just because you tested doesn't make the race go away; its not like
the fs has locks.

-A


Replies:
Re: [PATCH] prune_libtool_files(): go into .a removal only when .a exists.
-- Zac Medico
References:
[PATCH] prune_libtool_files(): go into .a removal only when .a exists.
-- Michał Górny
Re: [PATCH] prune_libtool_files(): go into .a removal only when .a exists.
-- Michael Orlitzky
Re: [PATCH] prune_libtool_files(): go into .a removal only when .a exists.
-- Michał Górny
Navigation:
Lists: gentoo-dev: < Prev By Thread Next > < Prev By Date Next >
Previous by thread:
Re: [PATCH] prune_libtool_files(): go into .a removal only when .a exists.
Next by thread:
Re: [PATCH] prune_libtool_files(): go into .a removal only when .a exists.
Previous by date:
Packages up for grabs due volkmar being unable to maintain them because of lack of time
Next by date:
Packages up for grabs due cla retirement


Updated Jun 29, 2012

Summary: Archive of the gentoo-dev mailing list.

Donate to support our development efforts.

Copyright 2001-2013 Gentoo Foundation, Inc. Questions, Comments? Contact us.