Gentoo Archives: gentoo-dev

From: "Tomáš Chvátal" <scarabeus@g.o>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] Re: git-2.eclass final review
Date: Mon, 18 Apr 2011 09:45:48
Message-Id: 4DAC081C.2070400@gentoo.org
In Reply to: Re: [gentoo-dev] Re: git-2.eclass final review by James Cloos
1 -----BEGIN PGP SIGNED MESSAGE-----
2 Hash: SHA1
3
4 Dne 17.4.2011 20:31, James Cloos napsal(a):
5 > That looks good (by inspection).
6 >
7 > My only concern is the branch deletion in the non-bare update.
8 >
9 > First of all, * should be escaped. It seems to work OK with gnu grep,
10 > but it would be better to be explicit. (grep(1) says that only ?+{|()
11 > loose their meta-meaning in basic regexps.)
12 >
13 > Second, why delete the other branches at all? I'd rather have a
14 > complete clone. Just the checkout ought to be enough.
15 >
16 > Otherwise, cool.
17 >
18 > -JimC
19 They are local clones -> they can be deleted on remote already, so we
20 wipe them all expect master every time unless needed.
21
22 No need to escape it if it is in "". it is parsed as the char itself
23 like this.
24 -----BEGIN PGP SIGNATURE-----
25 Version: GnuPG v2.0.17 (GNU/Linux)
26 Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
27
28 iEYEARECAAYFAk2sCBwACgkQHB6c3gNBRYddlgCfcK1sl4NKmOBWDWP9AJtEzgyw
29 VGEAmgLY4roHyg8+2szY/lB0B30jaZZv
30 =X/fM
31 -----END PGP SIGNATURE-----

Replies

Subject Author
Re: [gentoo-dev] Re: git-2.eclass final review James Cloos <cloos@×××××××.com>