Gentoo Logo
Gentoo Spaceship




Note: Due to technical difficulties, the Archives are currently not up to date. GMANE provides an alternative service for most mailing lists.
c.f. bug 424647
List Archive: gentoo-dev
Navigation:
Lists: gentoo-dev: < Prev By Thread Next > < Prev By Date Next >
Headers:
To: gentoo-dev@g.o
From: Petteri R├Ąty <betelgeuse@g.o>
Subject: Re: Minor changes in python.eclass and distutils.eclass
Date: Tue, 06 Jul 2010 09:33:43 +0300
On 07/06/2010 02:18 AM, Jeroen Roovers wrote:
> On Mon, 05 Jul 2010 22:50:56 +0000
> "Jorge Manuel B. S. Vicetto" <jmbsvicetto@g.o> wrote:
> 
>> I'm not going to delve into the details that have been addressed all
>> other this thread. Instead I'll just address one small issue.
>> The use of *minor* in the title of this thread and the sheer size of
>> the patch attached are not compatible. Please don't label changes
>> such as these as *minor* in future instances.
> 
> Another major flaw on its own is the sheer size of the patch (it hadn't
> been explicitly mentioned to my knowledge). Aren't we supposed to
> commit early and often in open source projects instead of dumping all
> your changes on reviewers at once (first fork and later merge)? And if
> you're still going to do it, a the huge patch should only be necessary
> to establish a single sweeping change, not many small changes.
> 

Indeed the patch should be splitted if you expect people to reasonably
review it.

Petteri

Attachment:
signature.asc (OpenPGP digital signature)
References:
Minor changes in python.eclass and distutils.eclass
-- Arfrever Frehtes Taifersar Arahesis
Re: Minor changes in python.eclass and distutils.eclass
-- Jorge Manuel B. S. Vicetto
Re: Minor changes in python.eclass and distutils.eclass
-- Jeroen Roovers
Navigation:
Lists: gentoo-dev: < Prev By Thread Next > < Prev By Date Next >
Previous by thread:
Re: Minor changes in python.eclass and distutils.eclass
Next by thread:
zlib ebuild from OSS-QM
Previous by date:
Re: [bugzilla-daemon@g.o: [Bug 326991] Testing release of sys-libs/zlib-1.2.5.3 from unofficial sources (???)]
Next by date:
Re: devmanual change notification


Updated Jun 29, 2012

Summary: Archive of the gentoo-dev mailing list.

Donate to support our development efforts.

Copyright 2001-2013 Gentoo Foundation, Inc. Questions, Comments? Contact us.