List Archive: gentoo-dev
Note: Due to technical difficulties, the Archives are currently not up to date.
provides an alternative service for most mailing lists.c.f. bug 424647
On 07/06/2010 02:18 AM, Jeroen Roovers wrote:
> On Mon, 05 Jul 2010 22:50:56 +0000
> "Jorge Manuel B. S. Vicetto" <email@example.com> wrote:
>> I'm not going to delve into the details that have been addressed all
>> other this thread. Instead I'll just address one small issue.
>> The use of *minor* in the title of this thread and the sheer size of
>> the patch attached are not compatible. Please don't label changes
>> such as these as *minor* in future instances.
> Another major flaw on its own is the sheer size of the patch (it hadn't
> been explicitly mentioned to my knowledge). Aren't we supposed to
> commit early and often in open source projects instead of dumping all
> your changes on reviewers at once (first fork and later merge)? And if
> you're still going to do it, a the huge patch should only be necessary
> to establish a single sweeping change, not many small changes.
Indeed the patch should be splitted if you expect people to reasonably