List Archive: gentoo-dev
Note: Due to technical difficulties, the Archives are currently not up to date.
provides an alternative service for most mailing lists.c.f. bug 424647
-----BEGIN PGP SIGNED MESSAGE-----
On 06/08/2012 04:24 PM, Michał Górny wrote:
> On Fri, 08 Jun 2012 16:06:27 +0200 hasufell <firstname.lastname@example.org>
>> On 06/08/2012 03:55 PM, Michał Górny wrote:
>>> On Fri, 08 Jun 2012 15:34:32 +0200 Is there a need for that?
>> I don't know, do you?
> Estimated to three packages, two in gx86, one in betagarden. All of
> them grabbing zipballs from github, so can be easily changed to
> download tarballs instead.
> Do you see a reason why they should use zipballs which are larger
> and require adding unzip to DEPEND rather than tarballs? The only
> reason for that I can see is that they copy-pasted the 'download'
> URI from somewhere where author posted only zipball link.
a) gentoo supports zip and zip is available.
Not supporting zip would need a comment or a conditional error.
Neither is implemented in the current code. Then you can start telling
users what they should use and what not.
b) future proof
c) less breakage, less confusion
>> This reduces the amount of archives the eclass can handle.
>> Unless gentoo decides to drop zip support I don't see a reason to
>> do that in an eclass too just for the sake of code-style.
> It's for a sake of code & work amount. And zip support in Gentoo is
> not obligatory. You need to add unzip to your DEPEND yourself.
>> My previous implementation had no trouble with zipballs. So if
>> you suggest a new implementation I would expect that to be
> Your previous implementation was against the KISS principle.
Your implementation breaks existing functionality.
- -1 for this
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
-----END PGP SIGNATURE-----