Gentoo Logo
Gentoo Spaceship




Note: Due to technical difficulties, the Archives are currently not up to date. GMANE provides an alternative service for most mailing lists.
c.f. bug 424647
List Archive: gentoo-dev
Navigation:
Lists: gentoo-dev: < Prev By Thread Next > < Prev By Date Next >
Headers:
To: gentoo-dev@g.o
From: Mike Frysinger <vapier@g.o>
Subject: Re: [PATCH] prune_libtool_files(): go into .a removal only when .a exists.
Date: Fri, 15 Jun 2012 16:05:29 -0400
On Friday 15 June 2012 12:52:56 Michał Górny wrote:
> On Fri, 15 Jun 2012 11:11:58 -0400 wrote:
> > On Friday 15 June 2012 09:32:18 Michał Górny wrote:
> > >  		# Remove static libs we're not supposed to link
> > > 
> > > against. if grep -q '^shouldnotlink=yes$' "${f}"; then
> > > -			einfo "Removing unnecessary
> > > ${archivefile#${D%/}}"
> > > -			rm -f "${archivefile}"
> > > +			if [[ -f ${archivefile} ]]; then
> > > +				einfo "Removing unnecessary
> > > ${archivefile#${D%/}} (static
> > plugin)"
> > > +				rm -f "${archivefile}"
> > > +			fi
> > 
> > highly unlikely, but this would skip symlinks that are broken in $D,
> > but valid once merged into $ROOT
> 
> Are you suggesting || -L?

if you want to be pessimistic that someday this might happen, then yeah.  or 
just leave it and wait for someone to complain.

> Not that I see a case where an external-symlink .a is installed alongside
> local .la file...

true.  probably not common (or even uncommon), but not impossible.
-mike
Attachment:
signature.asc (This is a digitally signed message part.)
References:
[PATCH] prune_libtool_files(): go into .a removal only when .a exists.
-- Michał Górny
Re: [PATCH] prune_libtool_files(): go into .a removal only when .a exists.
-- Mike Frysinger
Re: [PATCH] prune_libtool_files(): go into .a removal only when .a exists.
-- Michał Górny
Navigation:
Lists: gentoo-dev: < Prev By Thread Next > < Prev By Date Next >
Previous by thread:
Re: [PATCH] prune_libtool_files(): go into .a removal only when .a exists.
Next by thread:
Packages up for grabs due volkmar being unable to maintain them because of lack of time
Previous by date:
Re: ebuild laziness and binpkg overhead
Next by date:
Re: UEFI secure boot and Gentoo


Updated Jun 29, 2012

Summary: Archive of the gentoo-dev mailing list.

Donate to support our development efforts.

Copyright 2001-2013 Gentoo Foundation, Inc. Questions, Comments? Contact us.