Gentoo Archives: gentoo-dev

From: Mike Frysinger <vapier@g.o>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] pax-utils.eclass: elog -> einfo?
Date: Thu, 17 Mar 2011 22:19:01
Message-Id: 201103171818.21013.vapier@gentoo.org
In Reply to: Re: [gentoo-dev] pax-utils.eclass: elog -> einfo? by "Kevin F. Quinn"
1 On Thursday, March 17, 2011 17:59:44 Kevin F. Quinn wrote:
2 > On Sun, 13 Mar 2011 17:38:29 -0400
3 >
4 > "Anthony G. Basile" <blueness@g.o> wrote:
5 > > On 03/13/2011 04:19 PM, Mike Frysinger wrote:
6 > > > On Saturday, March 12, 2011 07:36:35 Paweł Hajdan, Jr. wrote:
7 > > >> I wonder why pax-utils.eclass uses elog instead of just einfo. An
8 > > >>
9 > > >> example message looks like this:
10 > > >> * Fallback PaX marking -m
11 > > >> * out/Release/chrome
12 > > >>
13 > > >> IMHO it's not very useful in the elog messages, but maybe there are
14 > > >> scenarios in which it is useful.
15 > > >>
16 > > >> My idea is to just replace all elogs with einfos in
17 > > >> pax-utils.eclass. What do you think?
18 > > >
19 > > > i think it depends on the person. for people who dont use
20 > > > grsec/PaX, they probably could care less and never see this
21 > > > output. for people who do, they probably do want to see this.
22 > > >
23 > > > maybe have it `elog` only when [[ $(uname -r) == *-grsec* ]]
24 > > > -mike
25 > >
26 > > blueness@yellowness ~ $ uname -r
27 > > 2.6.37-hardened-r5
28 > >
29 > > so you need == *-hardened-*
30 >
31 > I'd suggest doing something like:
32 >
33 > use hardened && elog ...
34 >
35 > There's an argument that it's better to make decisions according to
36 > make.conf settings rather than the host system configuration, not
37 > least to cater for people doing cross-builds. Assuming cross builds
38 > work at all; I've not tried that for a long time.
39
40 in general, yes. but this would have the unpleasant side effect of having
41 IUSE=hardened show up for all packages that inherit the eclass.
42
43 also, this code is run at the pkg_* stage, so it's not the normal src host
44 feature detection. and we're talking about minor output behavior.
45 -mike

Attachments

File name MIME type
signature.asc application/pgp-signature

Replies