Donnie Berkholz -  9:59 13.09.11 wrote:
> On 13:11 Tue 13 Sep     , Michal Hrusecky wrote:
> > # Copyright 1999-2011 Gentoo Foundation
> > # Distributed under the terms of the GNU General Public License v2
> > # $Header: $
> > 
> > # @ECLASS: obs-download.eclass
> 
> Are there going to be lots of packages using this and not the other 
> eclass? I wonder whether there really need to be two of them.

Two more currently.

> > # @MAINTAINER:
> > # miska@g.o
> > # @BLURB: Reduces code duplication in the downloading from obs.
> 
> Could you tell us what "obs" is in the blurb too? I had no clue what 
> this email was about (obs, osc, etc are meaningless to me) until I got 
> down to the eclass description.

Fixed

> > # @ECLASS: obs-service.eclass
> > # @MAINTAINER:
> > # miska@g.o
> > # @BLURB: Reduces code duplication in the obs services.
> > # @DESCRIPTION:
> > # This eclass makes it easier to package obs services. Based on provided
> > # information it will all neede variables and takes care of installation.
> 
> Lots of typos here.

Sorry, fixed.

> > HOMEPAGE="http://en.opensuse.org/openSUSE:OSC"
> > LICENSE="GPL-2"
> > SLOT="0"
> > IUSE=""
> > RDEPEND+="dev-util/osc"
> 
> You probably want a space here.
> 
> RDEPEND+=" dev-util/osc"

Thanks, fixed.

-- 
	Michal Hrusecky <miska@g.o>