| 1 |
El lun, 30-04-2012 a las 10:05 -0700, Zac Medico escribió: |
| 2 |
> On 04/29/2012 09:45 AM, Petteri Räty wrote: |
| 3 |
> > On 15.04.2012 17:12, Pacho Ramos wrote: |
| 4 |
> >> El dom, 15-04-2012 a las 16:02 +0200, Michał Górny escribió: |
| 5 |
> >>> On Sun, 15 Apr 2012 11:59:50 +0200 |
| 6 |
> >>> Pacho Ramos <pacho@g.o> wrote: |
| 7 |
> >>> |
| 8 |
> >>>> I am unsure about validate_desktop_entries() utility. It's currently |
| 9 |
> >>>> provided by eutils.eclass and only called by net-firewall/fwbuilder. |
| 10 |
> >>>> Shouldn't this be moved to a "qa" check? Current way is pretty useless |
| 11 |
> >>>> as it's not used by most of packages, and calling it from a lot of |
| 12 |
> >>>> eclasses/ebuilds doesn't sound me like a good idea. |
| 13 |
> >>>> |
| 14 |
> >>>> What do you think? |
| 15 |
> >>> |
| 16 |
> >>> Agreed. It should be in repoman. |
| 17 |
> >>> |
| 18 |
> >> |
| 19 |
> >> The check needs to be run over desktop file going to be installed, not |
| 20 |
> >> sure how repoman can handle it, it looked to me more like a emerge job |
| 21 |
> >> (like is done with other qa checks run before installation) |
| 22 |
> > |
| 23 |
> > There's actually already code in repoman that runs |
| 24 |
> > desktop-file-validate. It of course only works for installed packages. |
| 25 |
> > Someone could make it run runtime too. |
| 26 |
> |
| 27 |
> The repoman code works on $FILESDIR. It looks like we also want to run |
| 28 |
> it after src_install. |
| 29 |
> |
| 30 |
> Also, it looks like we might need to handle a special case for Konqueror |
| 31 |
> Service Menus: |
| 32 |
> |
| 33 |
> https://bugs.gentoo.org/show_bug.cgi?id=414125 |
| 34 |
|
| 35 |
Yes, I would like to also check other desktop files than those coming |
| 36 |
from FILESDIR |
Archives