1 |
On Sat, Aug 14, 2010 at 08:00:40PM +0300, Markos Chandras wrote: |
2 |
> On Sat, Aug 14, 2010 at 07:16:26PM +0300, Alex Alexander wrote: |
3 |
> > Does respecting LDFLAGS change the installed files in any way? yes. |
4 |
> > Will users benefit from your change if you don't revbump? No. |
5 |
> > |
6 |
> > I think that chain of logic is enough to warrant a revbump and it is |
7 |
> > covered by the devmanual since the change affects the installed package. |
8 |
> No it doesn't. If it was that clear we wouldn't debated over this over and |
9 |
> over. The cvs logs and you will see that other devs are fixing the package |
10 |
> without revbump. |
11 |
|
12 |
The fact that others do what you do doesn't automatically make it right. |
13 |
|
14 |
> > |
15 |
> > It's merely a cp, why are you making such a fuss about it? You're doing |
16 |
> > a good job already, we're just pointing out ways to make it even better |
17 |
> > |
18 |
> Cause I don't like users to compile the same damn package over and over. -r1 |
19 |
> for docs on ${PF}, -r2 for CFLGAS, -r3 for LDFLAGS, -r4 for ... Is that a good |
20 |
> reason or not? It is not like I introduce huge patches with bugfixes etc. My |
21 |
> fixes are QA fixes not *serious* bugfixes anyway. |
22 |
> Furthermore the QA fixes I do ( CC,CFLAGS,LDFLAGS ) are easily spotted and |
23 |
> there isn't much for users to test anyway. Either you respect the bloody flags |
24 |
> or not. I don't do blindly commits. I try to test the packages in multiple |
25 |
> chroots anyway. |
26 |
|
27 |
All your fixes are important else you wouldn't be doing them. |
28 |
|
29 |
I still don't understand why you don't want to revbump. |
30 |
|
31 |
Your changes may not affect program features but they do fix hidden |
32 |
issues. Issues that might help users later (for example, rebuilding a |
33 |
package with --as-needed may reduce revdep-rebuilds in the future). |
34 |
|
35 |
You can always try to reduce revbumps by doing all the things you |
36 |
mentioned together, if possible. |
37 |
|
38 |
In any case, unless we're talking about openoffice or kdelibs, revbumps |
39 |
don't really cost so much anymore. |
40 |
|
41 |
> > :) |
42 |
> > |
43 |
> > BTW, archs do the final testing, but much testing is done by the users |
44 |
> > themselves, who report the bugs that get fixed before the packages get a |
45 |
> > STABLEREQ bug ;) |
46 |
> Most of these bugs don't come from users but from Diego. Why? Because users |
47 |
> don't bother reading the build.log and see if all their flags are respected or |
48 |
> not. I wouldn't do it either. This |
49 |
|
50 |
I never said users report these specific bugs. But they will test *your* |
51 |
revbumps and may report other problems you didn't hit. |
52 |
|
53 |
> > > > Please, don't skip revbumps to avoid "tree spamming", thats why we have |
54 |
> > > > revbumps in the first place ;) |
55 |
> I am not convinced yet that this kind of QA fixes require a revbump. As I |
56 |
> said, commit an actual patch, assigned to QA and if the rest of the members |
57 |
> agree on that I am willing to change my policy. |
58 |
|
59 |
Now you're just being stubborn. I'm pretty sure your mentor told you "any |
60 |
change to installed files warrants a revbump" ;) |
61 |
|
62 |
Do we really need bureaucracy to enforce a commonly followed but not |
63 |
documented policy? |
64 |
|
65 |
> > > > > unless something is on stable branch, I fix it as it is. I don't want to |
66 |
> > > > > version bump anything because I don't want to mess with anyones |
67 |
> > > > > packages. I only do QA fixing. If you have problem touching your |
68 |
> > > > > packages just say it |
69 |
> > > > > > |
70 |
> > > > > > A. |
71 |
> > > > > > |
72 |
> > > > > > [1] https://bugs.gentoo.org/show_bug.cgi?id=332523 |
73 |
> > > > > |
74 |
> > > > > -- |
75 |
> > > > > Markos Chandras (hwoarang) |
76 |
> > > > > Gentoo Linux Developer |
77 |
> > > > > Web: http://hwoarang.silverarrow.org |
78 |
> > > > |
79 |
> > > > -- |
80 |
> > > > Alex Alexander -=- wired |
81 |
> > > > Gentoo Linux Developer -=- Council / Qt / KDE / more |
82 |
> > > > www.linuxized.com |
83 |
> > > |
84 |
> > > |
85 |
> > > |
86 |
> > > -- |
87 |
> > > Markos Chandras (hwoarang) |
88 |
> > > Gentoo Linux Developer |
89 |
> > > Web: http://hwoarang.silverarrow.org |
90 |
> > > Key ID: 441AC410 |
91 |
> > > Key FP: AAD0 8591 E3CD 445D 6411 3477 F7F7 1E8E 441A C410 |
92 |
> > |
93 |
> > |
94 |
> > |
95 |
> > -- |
96 |
> > Alex Alexander -=- wired |
97 |
> > Gentoo Linux Developer -=- Council / Qt / KDE / more |
98 |
> > www.linuxized.com |
99 |
> |
100 |
> |
101 |
> |
102 |
> -- |
103 |
> Markos Chandras (hwoarang) |
104 |
> Gentoo Linux Developer |
105 |
> Web: http://hwoarang.silverarrow.org |
106 |
> Key ID: 441AC410 |
107 |
> Key FP: AAD0 8591 E3CD 445D 6411 3477 F7F7 1E8E 441A C410 |
108 |
|
109 |
|
110 |
|
111 |
-- |
112 |
Alex Alexander -=- wired |
113 |
Gentoo Linux Developer -=- Council / Qt / KDE / more |
114 |
www.linuxized.com |