| 1 |
-----BEGIN PGP SIGNED MESSAGE----- |
| 2 |
Hash: SHA1 |
| 3 |
|
| 4 |
W dniu 17.07.2011 10:45, Kfir Lavi pisze: |
| 5 |
> Hi, |
| 6 |
> I have created a new ebuild for net-misc/pimd [1]. |
| 7 |
> From the webpage: |
| 8 |
> pimd is a lightweight stand-alone PIM-SM v2 multicast routing daemon. |
| 9 |
> |
| 10 |
> I would like you guys to review the ebuild and the rc-file. |
| 11 |
> This ebuild is based on net-misc/mrouted. |
| 12 |
|
| 13 |
> EAPI="2" |
| 14 |
Please use latest eapi when introducing new ebuilds |
| 15 |
|
| 16 |
> inherit eutils toolchain-funcs |
| 17 |
where do you use 'eutils.eclass'? |
| 18 |
|
| 19 |
> DESCRIPTION="Lightweight stand-alone PIM-SM v2 multicast routing daemon" |
| 20 |
> HOMEPAGE="http://vmlinux.org/jocke/pimd.shtml" |
| 21 |
> SRC_URI="ftp://ftp.vmlinux.org/pub/People/jocke/${PN}/${P}.tar.bz2" |
| 22 |
> LICENSE="Stanford" |
| 23 |
Is that a correct license? Compare LICENSE.mrouted with |
| 24 |
${PORTDIR}/licenses/Stanford and then with BSD. |
| 25 |
|
| 26 |
> SLOT="0" |
| 27 |
> KEYWORDS="~amd64 ~x86" |
| 28 |
> IUSE="+doc" |
| 29 |
Where do you use doc flag? |
| 30 |
|
| 31 |
> DEPEND="|| ( dev-util/yacc sys-devel/bison )" |
| 32 |
> RDEPEND="" |
| 33 |
Is yacc or bison really invoked during build? (Check either Makefile or |
| 34 |
TODO ;) ) Assuming it isn't those two lines are unnecessary. |
| 35 |
|
| 36 |
> CONFIG_CHECK="~IP_PIMSM_V2:" |
| 37 |
> WARNING_BRIDGE="CONFIG_IP_PIMSM_V2 is required for pimd" |
| 38 |
these are not used. |
| 39 |
|
| 40 |
> src_prepare() { |
| 41 |
> # Respect user CFLAGS, remove upstream optimisation and -Werror |
| 42 |
> sed -i Makefile \ |
| 43 |
> -e '/^CFLAGS/{s|[[:space:]]=| +=|g;s|-O2||g;s|-Werror||g}' \ |
| 44 |
> || die |
| 45 |
> } |
| 46 |
It would be more legible if you convert it to patch. |
| 47 |
|
| 48 |
> src_compile() { |
| 49 |
> emake CC=$(tc-getCC) || die |
| 50 |
> } |
| 51 |
Some systems export CC as "gcc -m64". |
| 52 |
|
| 53 |
> src_install() { |
| 54 |
> dobin pimd || die |
| 55 |
... |
| 56 |
All those helpers could be easily avoided. |
| 57 |
|
| 58 |
src_install() { |
| 59 |
emake DESTDIR="${D}" prefix=/usr \ |
| 60 |
datadir=/usr/share/doc/${PN} install || die |
| 61 |
newinitd "${FILESDIR}"/pimd.rc pimd |
| 62 |
} |
| 63 |
|
| 64 |
Only don't install unnecessary docs: |
| 65 |
sed -i -e "s/INSTALL LICENSE LICENSE.mrouted//" Makefile |
| 66 |
|
| 67 |
Please note that there's already bug for that pkg[1] it would be good if |
| 68 |
further development would be done there. |
| 69 |
Cheers, |
| 70 |
Kacper |
| 71 |
|
| 72 |
[1] https://bugs.gentoo.org/show_bug.cgi?id=352848 |
| 73 |
-----BEGIN PGP SIGNATURE----- |
| 74 |
Version: GnuPG v2.0.17 (GNU/Linux) |
| 75 |
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ |
| 76 |
|
| 77 |
iJwEAQECAAYFAk4irrgACgkQIiMqcbOVdxTfXAP/VAZi6HwGPRQrCzYTJ840brkb |
| 78 |
+KVBHUunzd+dML0m24oiq5CmR31SuYIpj4qXvsXuYYL2A2kK1N8R/A7KOcZ4MaGw |
| 79 |
BkltP/crrLJU6qHnTVrEXLE2SEYUxAGbTw2D4Lx0DE3jkLtikNDp/I2D0bS3aK9l |
| 80 |
/kuMMZp89zx293OeTBo= |
| 81 |
=QQI+ |
| 82 |
-----END PGP SIGNATURE----- |
Archives