[gentoo-dev] Re: Code review and main tree inclusion for java-mvn-src.eclass and java-pkg-simple.eclass

[Christian Faulhammer]

Hi,

Andrey Kislyuk <weaver@g.o>:
> ... and let's say after 30 days from this email pending resolution of
> any complaints mvg and I will push these to main tree.

 You should review your docstrings.  Some of them contain overlong
sentences, which are hard to grasp.

java-pkg-simple:
In my eyes, defining all local variables at the beginning of a function
makes it easier to read.

V-Li

-- 
Christian Faulhammer, Gentoo Lisp project
<URL:http://www.gentoo.org/proj/en/lisp/>, #gentoo-lisp on FreeNode

<URL:http://gentoo.faulhammer.org/>