Gentoo Archives: gentoo-dev

From: Mike Frysinger <vapier@g.o>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] enhancement for doicon/newicon in eutils.eclass
Date: Tue, 22 May 2012 02:35:51
Message-Id: 201205212235.46859.vapier@gentoo.org
In Reply to: Re: [gentoo-dev] enhancement for doicon/newicon in eutils.eclass by hasufell
1 On Monday 21 May 2012 15:58:24 hasufell wrote:
2 > On 05/21/2012 07:14 PM, Michał Górny wrote:
3 > > On Mon, 21 May 2012 01:24:13 +0200 hasufell wrote:
4 > >> I want support for installing icons into the appropriate
5 > >> directories which are under /usr/share/icons/... and not just
6 > >> pixmaps.
7 > >>
8 > >> proposal attached + diff
9 > >>
10 > >> This should not break existing ebuilds. Tested a bit and open
11 > >> for review now.
12 > >
13 > > I'd rather see a new function for that rather than making doicon()
14 > > overcomplex.
15 >
16 > The new features are totally optional, so there is nothing complex. If
17 > someone is looking for support for /usr/share/icons/... directories
18 > without setting insinto he can have it.
19 >
20 > doicon/newicon without options (should) behave exactly the same way.
21
22 i think he's talking about the actual implementation details (and yes, the
23 duplication of content should be solved rather than copying & pasting the guts
24 -- someone suggested a good fix for that) and the extended option set (which i
25 think we can live with).
26 -mike

Attachments

File name MIME type
signature.asc application/pgp-signature