Gentoo Archives: gentoo-dev

From: Sebastian Pipping <sping@g.o>
To: gentoo-dev@l.g.o
Cc: Stanislaw Pusep <creaktive@×××××.com>
Subject: [gentoo-dev] The feature patch mess in the webalizer ebuild (and how to deal with it)
Date: Wed, 10 Mar 2010 02:44:16
Message-Id: 4B97075B.8090605@gentoo.org
1 Hello!
2
3
4 Intro
5 =====
6 The latest version of webalizer is 2.01 while upstream is at 2.21 by
7 now. The reason it's not been bumped in Gentoo is the two use flags
8 "geoip" and "xtended".
9
10 The former alone pulls in a feature patch called "geolizer", while the
11 latter pulls a feature patch called "webalizer xtended", either with or
12 without geoip support.
13
14
15 Problem
16 =======
17 Both of these patches have not been updated for quite some time.
18 To bump webalizer we would either need fresh version of both patches
19 or drop what's out of date which breaks the use flags.
20
21 geoip support is included in webalizer itself by now. Still, geoalizer
22 added a bit more than that: human-readable byte units might still be
23 missing. With weblizer xtended if may be similar, at least that's my guess.
24
25
26 The real problem is that we have an ebuild depending on feature patches.
27 Even if we had updated patches by now it were a question of time only
28 until the symptoms return.
29
30
31 Solution
32 ========
33 1) Add two new packages to the tree:
34 - app-admin/geolizer (/usr/bin/geolizer)
35 - app-admin/webalizer-xtended (/usr/bin/webalizer-xtended)
36
37 2) Bump webalizer to 2.21 while
38 - no longer applying either feature patch
39 - removing use flag "xtended"
40 - keeping now hollow use flag "geoip" to reduce breakage
41
42 3) Close related bug 231859
43 https://bugs.gentoo.org/show_bug.cgi?id=231859
44
45 I volunteer to do that.
46
47 Any objections or suggestions?
48
49
50 Side note
51 =========
52 If anyone feels like playing around with merging changes from webalizer
53 into geolizer (and maybe geolizer-based webalizer xtended) he is welcome
54 to do that on top a dedicated Git repository for it:
55
56 http://git.goodpoint.de/?p=webalizer.git;a=summary
57
58 Contact me if that sounds like a job for you. Geolizer upstream is more
59 likely to migrate anytime soon, so checking back with Stanislaw Pusep
60 again before would be good.
61
62
63
64 Sebastian

Replies