| 1 |
2011/7/17 Ryan Hill <dirtyepic@g.o>: |
| 2 |
> On Sun, 17 Jul 2011 11:19:31 +0200 |
| 3 |
> justin <jlec@g.o> wrote: |
| 4 |
> |
| 5 |
>> On 17/07/11 11:16, Michał Górny wrote: |
| 6 |
>> > On Sun, 17 Jul 2011 11:05:39 +0200 |
| 7 |
>> > justin <jlec@g.o> wrote: |
| 8 |
>> > |
| 9 |
>> >> Hi all, |
| 10 |
>> >> |
| 11 |
>> >> the following change has some bad effects on packages in the tree. I |
| 12 |
>> >> found it with a package having this inherit line |
| 13 |
>> >> |
| 14 |
>> >> inherit cmake-utils wxwidgets |
| 15 |
>> >> |
| 16 |
>> >> all cmake-utils_* function which have redundant phase definitions in |
| 17 |
>> >> base will not be executed. |
| 18 |
>> >> |
| 19 |
>> >> This change was not trivial. So either we need to revert it or really |
| 20 |
>> >> check the tree that nothing is broken. |
| 21 |
>> > |
| 22 |
>> > Revert. The wxwidgets eclass is not really supposed to export phase |
| 23 |
>> > functions, I've seen packages in Sunrise using it along with |
| 24 |
>> > cmake-utils too. If someone wants user patches in their package, he/she |
| 25 |
>> > should inherit base directly and get phase funcs clean. |
| 26 |
>> > |
| 27 |
>> |
| 28 |
>> So I checked it. There are a couple of packages which use it in |
| 29 |
>> combination with cmake-utils, python and autotools-utils. And as |
| 30 |
>> maintainer keeps the lines sorted, all those ebuilds are broken potentially. |
| 31 |
> |
| 32 |
> And people wonder why I hate eclasses... |
| 33 |
> |
| 34 |
|
| 35 |
I would hate more seeing $PORTDIR go from 180MB to 1800MB, and a few |
| 36 |
more thing you already know ;) |
Archives