Archives
Archives
| From: | Ulrich Mueller <ulm@g.o> | ||
|---|---|---|---|
| To: | gentoo-dev@l.g.o | ||
| Subject: | Re: [gentoo-dev] [RFC] check-reqs.eclass.patch | ||
| Date: | Wed, 31 Aug 2011 16:40:29 | ||
| Message-Id: | 20062.25521.584332.373976@a1i15.kph.uni-mainz.de | ||
| In Reply to: | Re: [gentoo-dev] [RFC] check-reqs.eclass.patch by "Tomáš Chvátal" |
||
| 1 | >>>>> On Wed, 31 Aug 2011, TomᨠChvátal wrote: |
| 2 | |
| 3 | >> [M0-9]) echo "mebibytes" ;; |
| 4 | |
| 5 | > Anyway addressed :) |
| 6 | |
| 7 | Please be consistent and change the following occurences too: |
| 8 | |
| 9 | > # Internal function that returns number in megabites. |
| 10 | |
| 11 | > ewarn "QA: Assuming Megabytes." |
| 12 | |
| 13 | And the name of check-reqs_get_megs() is a misnomer then, maybe it |
| 14 | should be called check_reqs_get_size or check_reqs_get_memory? |
| 15 | |
| 16 | Ulrich |