| 1 |
> # @BLURB: Use this to easy install EMBOSS and EMBASSY programs (EMBOSS add-ons). |
| 2 |
|
| 3 |
do those need to be capitalized ? if upstream refers to them as |
| 4 |
EMBOSS and EMBASSY, then i guess it makes sense ... |
| 5 |
|
| 6 |
> # ebuild Variables can be extended (FOO+=" bar"). |
| 7 |
|
| 8 |
variables |
| 9 |
|
| 10 |
> # Example: |
| 11 |
> ... |
| 12 |
> # KEYWORDS="~amd64 ~ppc ~x86 ~amd64-linux ~x86-linux ~ppc-macos" |
| 13 |
|
| 14 |
not sure this makes sense in the example |
| 15 |
|
| 16 |
> # @ECLASS-VARIABLE: EBO_EAUTORECONF |
| 17 |
> # @DESCRIPTION: |
| 18 |
> # Set to 'no', if you don't want eautoreconf to be run after patching. |
| 19 |
|
| 20 |
isnt the opposite behavior the desired default ? generally running |
| 21 |
autotools is undesirable ... |
| 22 |
|
| 23 |
> : ${EBO_EAUTORECONF:="yes"} |
| 24 |
|
| 25 |
no need for quotes |
| 26 |
|
| 27 |
> inherit autotools eutils multilib |
| 28 |
|
| 29 |
i dont see multilib being used anywhere |
| 30 |
|
| 31 |
> DEPEND=" |
| 32 |
> dev-libs/expat |
| 33 |
> .... |
| 34 |
> RDEPEND="${DEPEND}" |
| 35 |
|
| 36 |
usually DEPEND is a superset of RDEPEND, so might make more sense to |
| 37 |
reverse these. not that it really matters. |
| 38 |
|
| 39 |
> S="${WORKDIR}"/${EF} |
| 40 |
|
| 41 |
no need for quotes |
| 42 |
|
| 43 |
> [[ -f "${FILESDIR}"/${PF}.patch ]] && epatch "${FILESDIR}"/${PF}.patch |
| 44 |
|
| 45 |
no need for quotes inside of this [[...]] |
| 46 |
|
| 47 |
> # runs econf with following options. Extra options can be passed by setting EBO_EXTRA_ECONF |
| 48 |
|
| 49 |
i'd add a "." to the end here, or just drop the 2nd sentence |
| 50 |
altogether. you already documented EBO_EXTRA_ECONF above, and the |
| 51 |
example shows it being used. |
| 52 |
|
| 53 |
> --docdir="${EPREFIX}/usr/share/doc/${PF}/" \ |
| 54 |
|
| 55 |
these arent typically specified with a trailing slash |
| 56 |
-mike |
Archives