Gentoo Logo
Gentoo Spaceship




Note: Due to technical difficulties, the Archives are currently not up to date. GMANE provides an alternative service for most mailing lists.
c.f. bug 424647
List Archive: gentoo-dev
Navigation:
Lists: gentoo-dev: < Prev By Thread Next > < Prev By Date Next >
Headers:
To: gentoo-dev@g.o
From: Michał Górny <mgorny@g.o>
Subject: Re: Re: [PATCH eutils] Move remove_libtool_files() from autotools-utils for wider use.
Date: Wed, 30 May 2012 19:16:15 +0200
On Tue, 29 May 2012 14:50:19 +0100
Steven J Long <slong@...> wrote:

> Michał Górny wrote:
> 
> > +  find "${D}" -type f -name '*.la' -print0 | while read -r -d ''
> > f; 
> ..
> > +	rm -f "${f}" || die
> ..
> > +  done
> 
> Don't pipe to read like that; it means the final command is in a
> subshell and "die is /not/ guaranteed to work correctly if called
> from a subshell environment."[1]

Didn't we actually change that in the past? I think I'm recalling
something like that...

> More seriously, the script doesn't actually get the correct
> filenames, despite being written to handle any filename.
> eg:
> $ touch $'  foo bar \n\t  '
> $ while read -r -d '' f; do echo "'$f'"; done < <(find . -type f
> -print0) './  foo bar'
> 
> You do it like this:
> 
> while read -rd ''; do
>    f=$REPLY;
>    ..
> done < <(find "$D" -type f -name '*.la' -print0)

Thanks.

-- 
Best regards,
Michał Górny
Attachment:
signature.asc (PGP signature)
References:
[PATCH eutils] Move remove_libtool_files() from autotools-utils for wider use.
-- Michał Górny
Re: [PATCH eutils] Move remove_libtool_files() from autotools-utils for wider use.
-- Steven J Long
Navigation:
Lists: gentoo-dev: < Prev By Thread Next > < Prev By Date Next >
Previous by thread:
Re: [PATCH eutils] Move remove_libtool_files() from autotools-utils for wider use.
Next by thread:
Re: [PATCH eutils] Move remove_libtool_files() from autotools-utils for wider use.
Previous by date:
Should packages auto-eselect alternative implementation on removal?
Next by date:
Re: Should packages auto-eselect alternative implementation on removal?


Updated Jun 29, 2012

Summary: Archive of the gentoo-dev mailing list.

Donate to support our development efforts.

Copyright 2001-2013 Gentoo Foundation, Inc. Questions, Comments? Contact us.