| 1 |
On Tue, Apr 13, 2010 at 4:55 PM, Peter Volkov <pva@g.o> wrote: |
| 2 |
> В Втр, 06/04/2010 в 07:43 +0530, Nirbheek Chauhan пишет: |
| 3 |
>> * It makes zero sense to manually manage ChangeLogs in git[1] |
| 4 |
> |
| 5 |
> Once I had stupid cut&paste mistake and entered wrong credits in |
| 6 |
> ChangeLog. I don't see how to resolve this issue in case ChangeLog's |
| 7 |
> will be generated from git log and until somebody suggests how to edit |
| 8 |
> ChangeLogs generated from git I think have to keep ChangeLogs in |
| 9 |
> gentoo-x86. |
| 10 |
> |
| 11 |
|
| 12 |
I didn't know that editing existing ChangeLog entries manually was an |
| 13 |
accepted practice with CVS. Even if it was to correct typos or |
| 14 |
something else. |
| 15 |
|
| 16 |
The traditional ChangeLog that is currently employed in gentoo-x86 |
| 17 |
(and in other projects) is simply an ugly hack to cheaply distribute |
| 18 |
commit messages to users in an offline manner. |
| 19 |
|
| 20 |
Think of it like this: if you make a typo in a commit message, or |
| 21 |
forget to add something; you can't change it after you've published |
| 22 |
the commit (cvs/svn commit or git push) to the world. Since ChangeLogs |
| 23 |
are offline commit messages; you shouldn't edit them either; only |
| 24 |
(app|pre)pend to them. |
| 25 |
|
| 26 |
Also, with git, you usually review and double-check your commits and |
| 27 |
amend/rebase before pushing, so such mistakes can be corrected then. |
| 28 |
And now that we have the ability to cheaply generate ChangeLogs from |
| 29 |
the commit messages, there is no reason to keep this ugly hack around. |
| 30 |
|
| 31 |
|
| 32 |
-- |
| 33 |
~Nirbheek Chauhan |
| 34 |
|
| 35 |
Gentoo GNOME+Mozilla Team |
Archives