Gentoo Logo
Gentoo Spaceship




Note: Due to technical difficulties, the Archives are currently not up to date. GMANE provides an alternative service for most mailing lists.
c.f. bug 424647
List Archive: gentoo-dev
Navigation:
Lists: gentoo-dev: < Prev By Thread Next > < Prev By Date Next >
Headers:
To: Gentoo Development <gentoo-dev@g.o>
From: Mike Frysinger <vapier@g.o>
Subject: Re: Patch for python.eclass
Date: Sun, 19 Sep 2010 21:45:14 -0400
On Sunday, September 19, 2010 21:18:51 Arfrever Frehtes Taifersar Arahesis 
wrote:
> -evaluated_PYTHONPATH="$(eval echo -n "${PYTHONPATH_template}")"
> +eval "evaluated_PYTHONPATH=\"${PYTHONPATH_template}\""

the quotes in the 2nd one are useless.  this should work the same:
	eval evaluated_PYTHONPATH=\"${PYTHONPATH_template}\"

while you're in the process of cleaning things up, i know we dont have a rule 
anywhere in terms of line length, but python.eclass has always struck me as a 
file with incredibly excessive line length.  comparing to other eclasses, it 
has multiple lines in it longer than any single line in any other eclass.

i normally develop in a terminal with 170 cols (which i think is larger than 
average), so i'm pretty lenient, but even python.eclass exceeds that multiple 
times if not running close to it.
-mike
Attachment:
signature.asc (This is a digitally signed message part.)
Replies:
Re: Re: Patch for python.eclass
-- Arfrever Frehtes Taifersar Arahesis
References:
Patch for python.eclass
-- Arfrever Frehtes Taifersar Arahesis
Navigation:
Lists: gentoo-dev: < Prev By Thread Next > < Prev By Date Next >
Previous by thread:
Patch for python.eclass
Next by thread:
Re: Re: Patch for python.eclass
Previous by date:
Re: openrc stabilization update
Next by date:
Re: Re: Patch for python.eclass


Updated Jun 29, 2012

Summary: Archive of the gentoo-dev mailing list.

Donate to support our development efforts.

Copyright 2001-2013 Gentoo Foundation, Inc. Questions, Comments? Contact us.