| 1 |
On Sunday, September 19, 2010 21:18:51 Arfrever Frehtes Taifersar Arahesis |
| 2 |
wrote: |
| 3 |
> -evaluated_PYTHONPATH="$(eval echo -n "${PYTHONPATH_template}")" |
| 4 |
> +eval "evaluated_PYTHONPATH=\"${PYTHONPATH_template}\"" |
| 5 |
|
| 6 |
the quotes in the 2nd one are useless. this should work the same: |
| 7 |
eval evaluated_PYTHONPATH=\"${PYTHONPATH_template}\" |
| 8 |
|
| 9 |
while you're in the process of cleaning things up, i know we dont have a rule |
| 10 |
anywhere in terms of line length, but python.eclass has always struck me as a |
| 11 |
file with incredibly excessive line length. comparing to other eclasses, it |
| 12 |
has multiple lines in it longer than any single line in any other eclass. |
| 13 |
|
| 14 |
i normally develop in a terminal with 170 cols (which i think is larger than |
| 15 |
average), so i'm pretty lenient, but even python.eclass exceeds that multiple |
| 16 |
times if not running close to it. |
| 17 |
-mike |
Archives