| 1 |
On 18-08-2011 16:57:59 +0200, Michał Górny wrote: |
| 2 |
> > # @ECLASS-VARIABLE: LC_PCAT |
| 3 |
> > # @DESCRIPTION: |
| 4 |
> > # Set this to the category of the plugin, if any. |
| 5 |
> > : ${LC_PCAT:=} |
| 6 |
> |
| 7 |
> Please use verbose variable names, and prefix them with eclass |
| 8 |
> filename; e.g. LEECHCRAFT_PLUGIN_CATEGORY. |
| 9 |
|
| 10 |
Really? The python eclass is full of such awkward overly verbose names. |
| 11 |
One can also exaggerate... |
| 12 |
|
| 13 |
> > if [ "${LC_PCAT+x}" != "x" ]; then |
| 14 |
> > CMAKE_USE_DIR="${S}/src/plugins/${LC_PCAT}/${PN#leechcraft-}" |
| 15 |
> > else |
| 16 |
> > if [[ ${PN} != "leechcraft-core" ]]; then |
| 17 |
> > CMAKE_USE_DIR="${S}/src/plugins/${PN#leechcraft-}" |
| 18 |
> > else |
| 19 |
> > CMAKE_USE_DIR="${S}/src" |
| 20 |
> > fi |
| 21 |
> > fi |
| 22 |
> |
| 23 |
> if-elif-else-fi. |
| 24 |
|
| 25 |
This sounds like a kind of bogus suggestion to me. Mixing use of [ and |
| 26 |
[[, on the other hand, is more what deserves attention here. |
| 27 |
|
| 28 |
|
| 29 |
|
| 30 |
-- |
| 31 |
Fabian Groffen |
| 32 |
Gentoo on a different level |
Archives