Gentoo Logo
Gentoo Spaceship




Note: Due to technical difficulties, the Archives are currently not up to date. GMANE provides an alternative service for most mailing lists.
c.f. bug 424647
List Archive: gentoo-dev
Navigation:
Lists: gentoo-dev: < Prev By Thread Next > < Prev By Date Next >
Headers:
To: gentoo-dev@g.o
From: Tomáš Chvátal <scarabeus@g.o>
Subject: Re: git-2: a bunch of patches to review
Date: Tue, 20 Sep 2011 22:46:10 +0200
0001 - i had reason to put local definitions on the top, it is way
more readable to see right away what local vars function has, so
please stick to it.
0004 - Did you ever hear that executing another code in condition is
damn annoying to trace? :)
0007 - I placed it into the conditionals to be clear what is
happening, what if there will be added another if without the push...
0010 - 0011 - I was serious with getting crashes on some packages with
this approach (suprisingly i first really tried to make the eclass
backcompat as much as possible), did you get anyone else to ack this
thing? FWIW it is like fetching new packages, I can agree that
dowloading whole qt or libreoffice can make someone sad, but it is
just few megs compared to the rest of your weekly world update. -> You
are introducing possibility to nicely fail without any simple
resolution why for almost no benefit.

Cheers

Tom


Replies:
Re: git-2: a bunch of patches to review
-- Michał Górny
Navigation:
Lists: gentoo-dev: < Prev By Thread Next > < Prev By Date Next >
Previous by thread:
RFC: Making backwards-incompatible tree changes | a solution for GLEP 55's problem
Next by thread:
Re: git-2: a bunch of patches to review
Previous by date:
Re: RFC: Making backwards-incompatible tree changes | a solution for GLEP 55's problem
Next by date:
Re: git-2: a bunch of patches to review


Updated Jun 29, 2012

Summary: Archive of the gentoo-dev mailing list.

Donate to support our development efforts.

Copyright 2001-2013 Gentoo Foundation, Inc. Questions, Comments? Contact us.