| 1 |
On Mon, 24 Oct 2011 03:42:24 +0000 |
| 2 |
Nathan Phillip Brink <binki@g.o> wrote: |
| 3 |
|
| 4 |
> On Sun, Oct 23, 2011 at 08:20:37PM +0200, Micha?? G??rny wrote: |
| 5 |
> > --- |
| 6 |
> > scons-utils.eclass | 33 +++++++++++++++++++++++++-------- |
| 7 |
> > 1 files changed, 25 insertions(+), 8 deletions(-) |
| 8 |
> ... |
| 9 |
> > +# @ECLASS-VARIABLE: myesconsargs |
| 10 |
> > +# @DEFAULT_UNSET |
| 11 |
> > +# @DESCRIPTION: |
| 12 |
> > +# List of package-specific options to pass to all SCons calls. |
| 13 |
> > Supposed to be +# set in src_configure(). |
| 14 |
> |
| 15 |
> Shouldn't this variable be named MYESCONSARGS since it is being |
| 16 |
> introduced into the global scope? |
| 17 |
|
| 18 |
I can't deny that but I'd like to keep it consistent with cmake-utils |
| 19 |
and autotools-utils. Alternate approach would be to make it local to |
| 20 |
src_configure() and add scons-utils_src_configure() which would export |
| 21 |
it under internal name but I don't think that's really worth the effort. |
| 22 |
|
| 23 |
-- |
| 24 |
Best regards, |
| 25 |
Michał Górny |
Archives