Gentoo Logo
Gentoo Spaceship




Note: Due to technical difficulties, the Archives are currently not up to date. GMANE provides an alternative service for most mailing lists.
c.f. bug 424647
List Archive: gentoo-dev
Navigation:
Lists: gentoo-dev: < Prev By Thread Next > < Prev By Date Next >
Headers:
To: gentoo-dev@g.o
From: Michał Górny <mgorny@g.o>
Subject: Re: git-2: a bunch of patches to review
Date: Wed, 21 Sep 2011 11:21:21 +0200
On Tue, 20 Sep 2011 22:46:10 +0200
Tomáš Chvátal <scarabeus@g.o> wrote:

> 0001 - i had reason to put local definitions on the top, it is way
> more readable to see right away what local vars function has, so
> please stick to it.
> 0007 - I placed it into the conditionals to be clear what is
> happening, what if there will be added another if without the push...

Ok, these two fixed/replaced.

-- 
Best regards,
Michał Górny
Attachment:
0001-Replace-variable-eval-s-with-foo.patch (Text Data)
Attachment:
0007-Move-pushd-popds-within-conditional-to-avoid-needles.patch (Text Data)
Attachment:
signature.asc (PGP signature)
References:
Re: git-2: a bunch of patches to review
-- Tomáš Chvátal
Navigation:
Lists: gentoo-dev: < Prev By Thread Next > < Prev By Date Next >
Previous by thread:
Re: git-2: a bunch of patches to review
Next by thread:
Re: git-2: a bunch of patches to review
Previous by date:
Re: Re: euscan proof of concept (like debian's uscan)
Next by date:
Re: Re: euscan proof of concept (like debian's uscan)


Updated Jun 29, 2012

Summary: Archive of the gentoo-dev mailing list.

Donate to support our development efforts.

Copyright 2001-2013 Gentoo Foundation, Inc. Questions, Comments? Contact us.