Gentoo Logo
Gentoo Spaceship




Note: Due to technical difficulties, the Archives are currently not up to date. GMANE provides an alternative service for most mailing lists.
c.f. bug 424647
List Archive: gentoo-dev
Navigation:
Lists: gentoo-dev: < Prev By Thread Next > < Prev By Date Next >
Headers:
To: gentoo-dev@g.o
From: Fabian Groffen <grobian@g.o>
Subject: Re: git-2: a bunch of patches to review
Date: Thu, 22 Sep 2011 09:47:52 +0200
On 22-09-2011 09:01:17 +0200, Ulrich Mueller wrote:
> > Attaching fixed version of the last two patches, and a complete
> > eclass for convenience.
> 
> Just a general comment: Is it really necessary to change all
> [[ -n ${foo} ]] and [[ -z ${foo} ]] conditionals to the more obscure
> [[ ${foo} ]] and [[ ! ${foo} ]]?
> 
> The shortest possible form is not always the one that's best readable.

+1

The style used is up to the maintainer.


-- 
Fabian Groffen
Gentoo on a different level
Attachment:
signature.asc (Digital signature)
References:
Re: git-2: a bunch of patches to review
-- Michał Górny
Re: git-2: a bunch of patches to review
-- Ulrich Mueller
Navigation:
Lists: gentoo-dev: < Prev By Thread Next > < Prev By Date Next >
Previous by thread:
Re: git-2: a bunch of patches to review
Next by thread:
Re: git-2: a bunch of patches to review
Previous by date:
Re: Please don't use IUSE=static-libs unless really necessary
Next by date:
Re: git-2: a bunch of patches to review


Updated Jun 29, 2012

Summary: Archive of the gentoo-dev mailing list.

Donate to support our development efforts.

Copyright 2001-2013 Gentoo Foundation, Inc. Questions, Comments? Contact us.