Hi,

welcome to your mentor reviews. :)

"Heath Caldwell (hncaldwell)" <hncaldwell@g.o>:

> Index: metadata.xml
> 		<flag name="kakasi">
> 			Enable <pkg>app-i18n/kakasi</pkg> support for
> furigana generation </flag>

 I tend to call it furigana instead of kakasi, as USE flags should
describe a purpose/function not the needed software to achieve it.

> Index: anki-0.9.8.1.ebuild
> ===================================================================
> # Copyright 1999-2008 Gentoo Foundation
> # Distributed under the terms of the GNU General Public License v2
> #
> $Header: /var/cvsroot/gentoo-x86/app-misc/anki/anki-0.9.8.1.ebuild,v
> 1.1 2008/10/02 23:13:39 hncaldwell Exp $
> 
> EAPI=1
> 
> NEED_PYTHON=2.4
> inherit eutils multilib python
> 
> DESCRIPTION="A spaced-repetition memory training program (flash
> cards)" HOMEPAGE="http://ichi2.net/anki/index.html"
> SRC_URI="http://ichi2.net/anki/download/${P}.tgz"
> LICENSE="GPL-3"
> SLOT="0"
> KEYWORDS="~amd64 ~x86"
> IUSE="+graph kakasi +sound"
> 
> RDEPEND=">=dev-python/PyQt4-4.3
> 	>=dev-python/sqlalchemy-0.4.1
> 	>=dev-python/simplejson-1.7.3
> 	>=dev-python/pysqlite-2.3.0

 pysqlite is included with Python 2.5 (USE=sqlite enabled), so you
might upgrade to EAPI=2 and use USE dependencies or add a
built_with_use check into pkg_config.  Or ask the Python team how to
handle it in the best way.

> src_install() {
> 	dodoc CREDITS
> 
> 	python_version
> 
> 	insinto "/usr/$(get_libdir)/python${PYVER}/site-packages"
> 	doins -r ankiqt libanki/anki
> 
> 	insinto "/usr/$(get_libdir)/python${PYVER}/site-packages/anki"
> 	doins -r designer icons icons.qrc icons_rc.py libanki/samples
> 
> 	dobin ${PN}
> 
> 	doicon icons/${PN}.png
> 	make_desktop_entry ${PN} ${PN} ${PN}.png "Education"
> }

 No installation routine available?

V-Li

-- 
Christian Faulhammer, Gentoo Lisp project
<URL:http://www.gentoo.org/proj/en/lisp/>, #gentoo-lisp on FreeNode

<URL:http://www.faulhammer.org/>