1 |
Okay, looks like there are no objections. I'll commit this tomorrow. |
2 |
|
3 |
On 02/21/2012 12:42 PM, Anthony G. Basile wrote: |
4 |
> Hi everyone, |
5 |
> |
6 |
> An issue came up with valgrind on the new multilib-portage which adds |
7 |
> CFLAGS_$target_abi to $CFLAGS [1]. Valgrind fails to compile when |
8 |
> -m64 is added because it needs to set its own abi flags. I tried to |
9 |
> filter-flags() it out; however, the -m64 flag also make it into |
10 |
> CCASFLAGS [2] which filter-flags() does touch. I see no reason not to |
11 |
> add CCASFLAGS to the list of flags filtered out by filter-flags(), so |
12 |
> I propose the following patch to flag-o-matic.eclass. Possible badness? |
13 |
> |
14 |
> --- flag-o-matic.eclass.orig 2012-02-21 12:38:37.000000000 -0500 |
15 |
> +++ flag-o-matic.eclass 2012-02-21 12:39:22.000000000 -0500 |
16 |
> @@ -17,7 +17,7 @@ |
17 |
> |
18 |
> # Return all the flag variables that our high level funcs operate on. |
19 |
> all-flag-vars() { |
20 |
> - echo {C,CPP,CXX,F,FC,LD}FLAGS |
21 |
> + echo {C,CPP,CXX,CCAS,F,FC,LD}FLAGS |
22 |
> } |
23 |
> |
24 |
> # {C,CXX,F,FC}FLAGS that we allow in strip-flags |
25 |
> @@ -101,7 +101,7 @@ |
26 |
> # @FUNCTION: filter-flags |
27 |
> # @USAGE: <flags> |
28 |
> # @DESCRIPTION: |
29 |
> -# Remove particular <flags> from {C,CPP,CXX,F,FC,LD}FLAGS. Accepts |
30 |
> shell globs. |
31 |
> +# Remove particular <flags> from {C,CPP,CXX,CCAS,F,FC,LD}FLAGS. |
32 |
> Accepts shell globs. |
33 |
> filter-flags() { |
34 |
> _filter-hardened "$@" |
35 |
> local v |
36 |
> |
37 |
> |
38 |
> |
39 |
> Ref. |
40 |
> [1] https://bugs.gentoo.org/show_bug.cgi?id=398825 |
41 |
> [2] http://www.delorie.com/gnu/docs/automake/automake_50.html |
42 |
> |
43 |
|
44 |
|
45 |
-- |
46 |
Anthony G. Basile, Ph.D. |
47 |
Gentoo Linux Developer [Hardened] |
48 |
E-Mail : blueness@g.o |
49 |
GnuPG FP : 8040 5A4D 8709 21B1 1A88 33CE 979C AF40 D045 5535 |
50 |
GnuPG ID : D0455535 |