Gentoo Logo
Gentoo Spaceship

Installation:
Gentoo Handbook
Installation Docs

Documentation:
Home
Listing
About Gentoo
Philosophy
Social Contract

Resources:
Bug Tracker
Developer List
Discussion Forums
Gentoo BitTorrents
Gentoo Linux Enhancement Proposals
IRC Channels
Mailing Lists
Mirrors
Name and Logo Guidelines
Online Package Database
Security Announcements
Staffing Needs
Supporting Vendors
View our CVS

Graphics:
Logos and themes
Icons
ScreenShots

Miscellaneous Resources:
Gentoo Linux Store
Gentoo-hosted projects
IBM dW/Intel article archive




List Archive: gentoo-dev
Navigation:
Lists: gentoo-dev: < Prev By Thread Next > < Prev By Date Next >
Headers:
To: gentoo-dev@g.o, fordfrog@g.o
From: Peter Volkov <pva@g.o>
Subject: Re: [gentoo-commits] gentoo-x86 commit in dev-util/netbeans: ChangeLog netbeans-6.5-r1.ebuild netbeans-6.5.ebuild
Date: Sat, 22 Nov 2008 22:02:43 +0300
В Сбт, 22/11/2008 в 18:11 +0000, Miroslav Sulc (fordfrog) пишет:
> fordfrog    08/11/22 18:11:25
>   Added:                netbeans-6.5-r1.ebuild
>   Log: netbeans compiles fine even with JDK 1.6 so I dropped the restriction on JDK, also commons-fileupload linking fixed

> Index: netbeans-6.5-r1.ebuild
> ===================================================================
> pkg_setup() {
> 	if use netbeans_modules_apisupport && ! ( use netbeans_modules_harness && use netbeans_modules_ide && use netbeans_modules_java ) ; then
> 		eerror "'apisupport' USE flag requires 'harness', 'ide' and 'java' USE flags"
> 		exit 1
> 	fi

Why do you use exit 1 instead of die?

> 	local tmpfileplatform="${T}/platform.txt"
> 	cat ${tmpfile} | grep -v "libs.jna/external/jna-3.0.2.jar" > ${tmpfileplatform}
> 	mv ${tmpfileplatform} ${tmpfile}

grep can read files on it's own so no need for cat file | grep... Also possibly

sed -e "/libs\.jna\/external\/jna-3\.0\.2\.jar/d" -i ${tmpfile}

will work better here and in some other places...

-- 
Peter.



Replies:
Re: Re: [gentoo-commits] gentoo-x86 commit in dev-util/netbeans: ChangeLog netbeans-6.5-r1.ebuild netbeans-6.5.ebuild
-- Jeremy Olexa
Navigation:
Lists: gentoo-dev: < Prev By Thread Next > < Prev By Date Next >
Previous by thread:
Nominations open for 1 council slot
Next by thread:
Re: Re: [gentoo-commits] gentoo-x86 commit in dev-util/netbeans: ChangeLog netbeans-6.5-r1.ebuild netbeans-6.5.ebuild
Previous by date:
Nominations open for 1 council slot
Next by date:
Re: Re: [gentoo-commits] gentoo-x86 commit in dev-util/netbeans: ChangeLog netbeans-6.5-r1.ebuild netbeans-6.5.ebuild


Updated Jun 17, 2009

Donate to support our development efforts.

Gentoo Centric Hosting: vr.org

VR Hosted

Tek Alchemy

Tek Alchemy

SevenL.net

SevenL.net

php|architect

php|architect

Copyright 2001-2007 Gentoo Foundation, Inc. Questions, Comments? Email www@gentoo.org.