1 |
On Thu, 01 Sep 2011 14:56:42 +0200 |
2 |
Tomáš Chvátal <scarabeus@g.o> wrote: |
3 |
|
4 |
> > That function doesn't follow do*() argument scheme; it matches |
5 |
> > rather one used by new*() funcs. Sadly, a number of ebuilds is |
6 |
> > using that scheme to rename installed file. |
7 |
> > |
8 |
> > Furthermore, it uses two eclass variables to switch the behavior. |
9 |
> > |
10 |
> > BASHCOMPFILES allows it to install multiple files (but works only |
11 |
> > if no arguments are passed). |
12 |
> > |
13 |
> > BASHCOMPLETION_NAME renames the installed file (if BASHCOMPFILES is |
14 |
> > not used) and makes it ignore the second argument. |
15 |
> > |
16 |
> > I think the way to go would be to reimplement it completely. Maybe |
17 |
> > just put dobashcomp() and newbashcomp() functions in eutils (to not |
18 |
> > collide) and deprecate bash-completion.eclass? |
19 |
> > |
20 |
> I would go with the eutils.eclass update, but remember that you have |
21 |
> to keep backcompat for the old call :( |
22 |
|
23 |
Ah, forgot about stats. |
24 |
|
25 |
dobashcompletion() with two args is used a lot of times. |
26 |
|
27 |
BASHCOMPFILES is used in ONE ebuild in gx86. |
28 |
BASHCOMPLETION_NAME is used in 4-5 ebuilds. |
29 |
|
30 |
We can either go with a new func and retroactively replace the eclass, |
31 |
or retroactively fix all uses and fix the old funcs. |
32 |
|
33 |
-- |
34 |
Best regards, |
35 |
Michał Górny |