Gentoo Archives: gentoo-dev

From: Jonathan Callen <abcd@g.o>
To: gentoo-dev@l.g.o
Subject: [gentoo-dev] Re: enhancement for doicon/newicon in eutils.eclass
Date: Mon, 21 May 2012 00:02:57
Message-Id: 4FB985E9.3030107@gentoo.org
In Reply to: Re: [gentoo-dev] enhancement for doicon/newicon in eutils.eclass by hasufell
1 -----BEGIN PGP SIGNED MESSAGE-----
2 Hash: SHA512
3
4 On 05/20/2012 07:49 PM, hasufell wrote:
5 > On 05/21/2012 01:36 AM, Alexis Ballier wrote:
6 >> On Mon, 21 May 2012 01:24:13 +0200 hasufell <hasufell@g.o>
7 >> wrote:
8 >>
9 >>> I want support for installing icons into the appropriate
10 >>> directories which are under /usr/share/icons/... and not just
11 >>> pixmaps.
12 >>>
13 >>> proposal attached + diff
14 >>>
15 >>> This should not break existing ebuilds. Tested a bit and open
16 >>> for review now.
17 >>
18 >> maybe i missed something but cant you just make doicon a newicon
19 >> wrapper and remove all that code duplication ?
20 >>
21 >
22 > I don't see how. "doicon" supports installing multiple icons with
23 > one command, as well as directories. That does not work for
24 > "newicon".
25 >
26 >
27
28 Normally, new* is a wrapper for do* that does something like:
29
30 newfoo() {
31 # argument checking omitted...
32 cp -P "${1}" "${T}/${2}"
33 dofoo "${T}/${2}"
34 }
35
36 - --
37 Jonathan Callen
38 -----BEGIN PGP SIGNATURE-----
39 Version: GnuPG v2.0.19 (GNU/Linux)
40 Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
41
42 iQIcBAEBCgAGBQJPuYXpAAoJELHSF2kinlg4C7kP/1tNBut+o5s0ScBt/SREjrQr
43 Oy1Q4iRk1hV5NqY0ve4Cx1LqT3LKFWGCUkUY9pY4YoacG5Pbt4FKebqHqBjNASbg
44 FIwA2BNGZ5VKW2uwfqpTcc2lp6VRAfA3IxqkO3mlKy/zwk96G3jeoU+2sLSRatRn
45 ZiXsuCQ6DxrBRp8Jtjc5X9lIvbfBNoDIC7uXtW8fOuFBILYT/oSDPwUdT9r3ppNR
46 nfEuB3AsjPEyxuSd0R7QNYXexwDwVyp4JlpqFAQGH/+xUR4Nsy4Cw5jVwOr6Ip+3
47 afDVC4NNkFBUf+8qQ/Rd6Fdch3RVLeGtdIfhHbYgSbmUGFjIOWQ/+kEy6yp8jNlp
48 2nkA29Y9eEmRYSwwfQR4xzTcWnuPyK9cNKuK2L5LTUN143rHJdQ85lzkhNPIAYJO
49 jQVPWZh966tQrjkLB9sfW14mkCcvkK5q9F4re5Z44R1RHfdnl+Npe7uts17dQSCg
50 61sdTQ4Q7r81SyqSgsf2g+QaaLQ+d7+HrZvEJ+N8xhDOwX06CZVjvNWnwewbHBUT
51 jWHkilE9wKJcliaAwK6wqCMNw0LZnvQJHWUKm+vNKcl1PSg51VeQrjEldPDix5cS
52 WVCjsFjzo4pLzID19pI1z3Yx7NIJJTbqfKw1Oju+Bv3JGAzz12RCX8XV4t9BCp7r
53 tPk3xzb4gsxPDqROppVh
54 =D2sX
55 -----END PGP SIGNATURE-----

Replies