[gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in app-office/abiword: abiword-2.4.6.ebuild

[Gilles Dartiguelongue]

Le jeudi 17 décembre 2009 à 10:54 +0000, Samuli Suominen (ssuominen) a
écrit :
> ssuominen    09/12/17 10:54:05
>
>   Modified:             abiword-2.4.6.ebuild
>   Log:
>   Fix quoting
>   (Portage version: 2.2_rc59/cvs/Linux x86_64)
>
> Revision  Changes    Path
> 1.16                 app-office/abiword/abiword-2.4.6.ebuild
>
> file : http://sources.gentoo.org/viewcvs.py/gentoo-x86/app-office/abiword/abiword-2.4.6.ebuild?rev=1.16&view=markup
> plain: http://sources.gentoo.org/viewcvs.py/gentoo-x86/app-office/abiword/abiword-2.4.6.ebuild?rev=1.16&content-type=text/plain
> diff : http://sources.gentoo.org/viewcvs.py/gentoo-x86/app-office/abiword/abiword-2.4.6.ebuild?r1=1.15&r2=1.16
>
> Index: abiword-2.4.6.ebuild
> ===================================================================
> RCS file: /var/cvsroot/gentoo-x86/app-office/abiword/abiword-2.4.6.ebuild,v
> retrieving revision 1.15
> retrieving revision 1.16
> diff -u -r1.15 -r1.16
> --- abiword-2.4.6.ebuild	4 Jan 2009 22:51:26 -0000	1.15
> +++ abiword-2.4.6.ebuild	17 Dec 2009 10:54:05 -0000	1.16
[...]
> @@ -65,12 +65,12 @@
>
>  src_install() {
>  	dodir /usr/{bin,lib}
> -	make DESTDIR="${D}" icondir="/usr/share/pixmaps" install || die "install failed"
> +	emake DESTDIR="${D}" icondir="/usr/share/pixmaps" install || die "install failed"

I see no bug report about checking this actually works and making the
fix. Please warn people before using your QA hat for doing things like
this.

-- 
Gilles Dartiguelongue <eva@g.o>
Gentoo